Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pruning should happen after Cleanup #2441

Merged
merged 2 commits into from
Jul 10, 2019

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Jul 10, 2019

Fixes #2440

Signed-off-by: David Gageot david@gageot.net

Fixes GoogleContainerTools#2440

Signed-off-by: David Gageot <david@gageot.net>
@codecov
Copy link

codecov bot commented Jul 10, 2019

Codecov Report

Merging #2441 into master will increase coverage by 0.33%.
The diff coverage is 31.81%.

Impacted Files Coverage Δ
pkg/skaffold/docker/image_util.go 0% <ø> (ø) ⬆️
pkg/skaffold/docker/image.go 70.58% <0%> (-5.21%) ⬇️
cmd/skaffold/app/cmd/dev.go 85% <100%> (+60%) ⬆️
pkg/skaffold/build/local/types.go 68.57% <50%> (+0.92%) ⬆️

Fixes GoogleContainerTools#2442

Signed-off-by: David Gageot <david@gageot.net>
@dgageot dgageot merged commit 09a42cf into GoogleContainerTools:master Jul 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pruning should happen after Cleanup
3 participants