Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pruning should happen after Cleanup #2440

Closed
dgageot opened this issue Jul 10, 2019 · 0 comments · Fixed by #2441
Closed

Pruning should happen after Cleanup #2440

dgageot opened this issue Jul 10, 2019 · 0 comments · Fixed by #2441
Assignees
@dgageot
Labels
area/cleanup kind/bug Something isn't working

Comments

@dgageot
Copy link
Contributor

dgageot commented Jul 10, 2019

Pruning currently happens before the cleanup. That makes it impossible to remove images that are used by the deployments.

$ skaffold dev --cache-artifacts=false
...
^CPruning images...
[getting-started] <Exited>
WARN[0004] builder cleanup: pruning images: Error response from daemon: conflict: unable to delete ee39ef7bb27f (cannot be forced) - image is being used by running container 2826bfebd98d
Cleaning up...
pod "getting-started" deleted
Cleanup complete in 8.152656959s
@dgageot dgageot added kind/bug Something isn't working area/cleanup labels Jul 10, 2019
@dgageot dgageot self-assigned this Jul 10, 2019
dgageot added a commit to dgageot/skaffold that referenced this issue Jul 10, 2019
@dgageot
Pruning should happen after Cleanup
53c8122 
Fixes GoogleContainerTools#2440

Signed-off-by: David Gageot <david@gageot.net>
@dgageot dgageot mentioned this issue Jul 10, 2019
Merged
dgageot added a commit that referenced this issue Jul 10, 2019
@dgageot
Pruning should happen after Cleanup (#2441)
09a42cf 
* Pruning should happen after Cleanup

Fixes #2440

Signed-off-by: David Gageot <david@gageot.net>

* Repair --no-prune-children

Fixes #2442

Signed-off-by: David Gageot <david@gageot.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dgageot dgageot

Labels
area/cleanup kind/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Pruning should happen after Cleanup dgageot/skaffold
1 participant
@dgageot