Support Cluster config with a path #2342

dgageot · 2019-06-26T13:07:19Z

codecov · 2019-06-26T13:40:36Z

Codecov Report

Merging #2342 into master will decrease coverage by 0.04%.
The diff coverage is 100%.

Impacted Files	Coverage Δ
pkg/skaffold/schema/defaults/defaults.go	`90.41% <100%> (ø)`	⬆️
pkg/skaffold/jib/jib.go	`76.34% <0%> (-2.16%)`	⬇️
pkg/skaffold/docker/client.go	`69.6% <0%> (-1.97%)`	⬇️

Add a test for GoogleContainerTools#2330 Signed-off-by: David Gageot <david@gageot.net>

Fix GoogleContainerTools#2330 Signed-off-by: David Gageot <david@gageot.net>

dgageot requested review from balopat, nkubala, priyawadhwa and tejal29 as code owners June 26, 2019 13:07

googlebot added the cla: yes label Jun 26, 2019

dgageot force-pushed the fix-2330 branch 7 times, most recently from c196e2a to 43a061e Compare June 28, 2019 15:10

dgageot added 2 commits June 29, 2019 00:17

Test skaffold.yaml files for regressions

0b5c6d7

Add a test for GoogleContainerTools#2330 Signed-off-by: David Gageot <david@gageot.net>

Support Cluster config with path to docker config

99b331c

Fix GoogleContainerTools#2330 Signed-off-by: David Gageot <david@gageot.net>

dgageot force-pushed the fix-2330 branch from 43a061e to 99b331c Compare June 28, 2019 22:17

priyawadhwa approved these changes Jul 1, 2019

View reviewed changes

dgageot merged commit daf58c6 into GoogleContainerTools:master Jul 1, 2019