Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skaffold run failing #2330

Closed
prary opened this issue Jun 25, 2019 · 1 comment · Fixed by #2342
Closed

skaffold run failing #2330

prary opened this issue Jun 25, 2019 · 1 comment · Fixed by #2342
Assignees
Labels
area/config kind/bug Something isn't working

Comments

@prary
Copy link
Contributor

prary commented Jun 25, 2019

Skaffold run fail's after upgrade

Expected behavior

Should build and deploy

Actual behavior

But skaffold fails with following error

FATA[0000] creating runner: invalid skaffold config: only one element in set dockerSecret can be set. got Path and SecretName

Information

apiVersion: skaffold/v1beta11
kind: Config
build:
  artifacts:
  - image: someurl
    context: .
    kaniko:
      buildContext:
        localDir: {}
  cluster:
    namespace: prashant
    dockerConfig:
      path: C:\Users\prashant\.docker\config.json
deploy:
  kubectl:
    manifests:
      - deploy.yml

Steps to reproduce the behavior

  1. Use latest skaffold and run with above yaml.

looks like

Path string yaml:"path,omitempty" yamltags:"oneOf=dockerSecret"

is the culpit

@dgageot dgageot self-assigned this Jun 26, 2019
@dgageot
Copy link
Contributor

dgageot commented Jun 26, 2019

Hi @prary, thanks for reporting and finding where the bug comes from. I'll try to fix it

dgageot added a commit to dgageot/skaffold that referenced this issue Jun 26, 2019
Add a test for GoogleContainerTools#2330


Signed-off-by: David Gageot <david@gageot.net>
dgageot added a commit to dgageot/skaffold that referenced this issue Jun 26, 2019
Fix GoogleContainerTools#2330

Signed-off-by: David Gageot <david@gageot.net>
@dgageot dgageot added area/config kind/bug Something isn't working labels Jun 26, 2019
dgageot added a commit to dgageot/skaffold that referenced this issue Jun 26, 2019
Fix GoogleContainerTools#2330

Signed-off-by: David Gageot <david@gageot.net>
dgageot added a commit to dgageot/skaffold that referenced this issue Jun 26, 2019
Fix GoogleContainerTools#2330

Signed-off-by: David Gageot <david@gageot.net>
dgageot added a commit to dgageot/skaffold that referenced this issue Jun 26, 2019
Add a test for GoogleContainerTools#2330


Signed-off-by: David Gageot <david@gageot.net>
dgageot added a commit to dgageot/skaffold that referenced this issue Jun 26, 2019
Fix GoogleContainerTools#2330

Signed-off-by: David Gageot <david@gageot.net>
dgageot added a commit to dgageot/skaffold that referenced this issue Jun 27, 2019
Add a test for GoogleContainerTools#2330


Signed-off-by: David Gageot <david@gageot.net>
dgageot added a commit to dgageot/skaffold that referenced this issue Jun 27, 2019
Fix GoogleContainerTools#2330

Signed-off-by: David Gageot <david@gageot.net>
dgageot added a commit to dgageot/skaffold that referenced this issue Jun 27, 2019
Add a test for GoogleContainerTools#2330


Signed-off-by: David Gageot <david@gageot.net>
dgageot added a commit to dgageot/skaffold that referenced this issue Jun 27, 2019
Fix GoogleContainerTools#2330

Signed-off-by: David Gageot <david@gageot.net>
dgageot added a commit to dgageot/skaffold that referenced this issue Jun 27, 2019
Add a test for GoogleContainerTools#2330


Signed-off-by: David Gageot <david@gageot.net>
dgageot added a commit to dgageot/skaffold that referenced this issue Jun 27, 2019
Fix GoogleContainerTools#2330

Signed-off-by: David Gageot <david@gageot.net>
dgageot added a commit to dgageot/skaffold that referenced this issue Jun 28, 2019
Add a test for GoogleContainerTools#2330


Signed-off-by: David Gageot <david@gageot.net>
dgageot added a commit to dgageot/skaffold that referenced this issue Jun 28, 2019
Fix GoogleContainerTools#2330

Signed-off-by: David Gageot <david@gageot.net>
dgageot added a commit to dgageot/skaffold that referenced this issue Jun 28, 2019
Add a test for GoogleContainerTools#2330


Signed-off-by: David Gageot <david@gageot.net>
dgageot added a commit to dgageot/skaffold that referenced this issue Jun 28, 2019
Fix GoogleContainerTools#2330

Signed-off-by: David Gageot <david@gageot.net>
dgageot added a commit that referenced this issue Jul 1, 2019
* Support Cluster config with path to docker config

Fix #2330

Signed-off-by: David Gageot <david@gageot.net>

* Test skaffold.yaml files for regressions

Add a test for #2330


Signed-off-by: David Gageot <david@gageot.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/config kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants