-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skaffold helm deploy, add support for optional --timemout flag and --force flags #1507
Conversation
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
@moustafab can you sign the SLA? |
Codecov Report
@@ Coverage Diff @@
## master #1507 +/- ##
==========================================
- Coverage 44.87% 44.82% -0.05%
==========================================
Files 115 115
Lines 4771 4776 +5
==========================================
Hits 2141 2141
- Misses 2409 2413 +4
- Partials 221 222 +1
Continue to review full report at Codecov.
|
I signed it! The bot seems to be having an issue. |
@dgageot My org contact signed the agreement on 1/18, and I'm part of the google group. Let me know if I need to do anything |
@moustafab click this link to see if you signed it: https://cla.developers.google.com/ |
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
confirmed @googlebot I hereby consent, as long as you merge sooner rather than later. I need these for my team to be able to easily use this tool, and I'd rather not have to get everyone pulling from somewhere other than the main repository! |
I signed it |
I'm confused about the Google bot. We both signed but it's still complaining. |
@tjerkw hmm, did you both sign the commit with the same email you have the CLA signed with? I've had this issue before where I accidentally signed the commit with my personal email. |
also, unfortunately you'll need a rebase now :( |
As agreed here, lets use the Flags based approach: |
This combines two pull requests for adding helm flags.
-- timeout flag for helm
Since we support --wait we should add --timeout too
#1506
And the --force flag for helm.
#1499
Updated docs.