Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skaffold helm deploy, add support for optional --timemout flag and --force flags #1507

Closed
wants to merge 12 commits into from

Conversation

tjerkw
Copy link

@tjerkw tjerkw commented Jan 22, 2019

This combines two pull requests for adding helm flags.

-- timeout flag for helm
Since we support --wait we should add --timeout too
#1506

And the --force flag for helm.
#1499

Updated docs.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@tjerkw
Copy link
Author

tjerkw commented Jan 22, 2019

@moustafab can you sign the SLA?

@codecov-io
Copy link

codecov-io commented Jan 22, 2019

Codecov Report

Merging #1507 into master will decrease coverage by 0.04%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1507      +/-   ##
==========================================
- Coverage   44.87%   44.82%   -0.05%     
==========================================
  Files         115      115              
  Lines        4771     4776       +5     
==========================================
  Hits         2141     2141              
- Misses       2409     2413       +4     
- Partials      221      222       +1
Impacted Files Coverage Δ
pkg/skaffold/deploy/helm.go 63.22% <0%> (-1.46%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51bcca6...eb0de47. Read the comment docs.

@moustafab
Copy link

I signed it! The bot seems to be having an issue.

@moustafab
Copy link

@dgageot My org contact signed the agreement on 1/18, and I'm part of the google group. Let me know if I need to do anything

@tjerkw
Copy link
Author

tjerkw commented Jan 23, 2019

@moustafab click this link to see if you signed it: https://cla.developers.google.com/

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

@moustafab
Copy link

confirmed @googlebot I hereby consent, as long as you merge sooner rather than later.
@tjerkw Thanks for putting these together!

I need these for my team to be able to easily use this tool, and I'd rather not have to get everyone pulling from somewhere other than the main repository!

@tjerkw
Copy link
Author

tjerkw commented Jan 26, 2019

I signed it

@tjerkw
Copy link
Author

tjerkw commented Jan 26, 2019

I'm confused about the Google bot. We both signed but it's still complaining.

@dgageot dgageot added the kokoro:run runs the kokoro jobs on a PR label Jan 28, 2019
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Jan 28, 2019
@nkubala
Copy link
Contributor

nkubala commented Feb 6, 2019

@tjerkw hmm, did you both sign the commit with the same email you have the CLA signed with? I've had this issue before where I accidentally signed the commit with my personal email.

@nkubala
Copy link
Contributor

nkubala commented Feb 6, 2019

also, unfortunately you'll need a rebase now :(

@tjerkw
Copy link
Author

tjerkw commented Feb 11, 2019

As agreed here, lets use the Flags based approach:
#1506

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants