-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for helm --force flag #1499
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
I signed it! |
CLAs look good, thanks! |
Codecov Report
@@ Coverage Diff @@
## master #1499 +/- ##
==========================================
- Coverage 44.87% 44.85% -0.02%
==========================================
Files 115 115
Lines 4771 4773 +2
==========================================
Hits 2141 2141
- Misses 2409 2410 +1
- Partials 221 222 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one comment, but once that is addressed this should be ready!
@@ -183,6 +183,7 @@ deploy: | |||
|
|||
# helm: | |||
# helm releases to deploy. | |||
# Uses "helm install" if not installed yet, otherwise "helm upgrade" is executed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, unfortunately because of the way we have to release config changes, this change also needs to be made in integration/examples/annotated-skaffold.yaml. Would you mind adding it there as well? Thanks!
As agreed here, lets use the flag based approach: |
We're using skaffold and helm to deploy. In our ci-cluster deploys sometimes fail,
but then skaffold cannot install it anymore if it finds a failed helm installation.
The --force flag solves this.
See the --force functionailtiy added in helm 2.5.0:
helm/helm#2280
Potential solution for #1328
Makes it more easy to use skaffold in a ci-pipeline. (deploy from a clean sheet)