Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don’t assume bazel-bin is symlinked in workspace #1340

Merged
merged 2 commits into from
Nov 30, 2018

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Nov 30, 2018

Fix #1319

@codecov-io
Copy link

Codecov Report

Merging #1340 into master will increase coverage by 0.27%.
The diff coverage is 45.45%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1340      +/-   ##
==========================================
+ Coverage   44.74%   45.02%   +0.27%     
==========================================
  Files         114      114              
  Lines        4890     4900      +10     
==========================================
+ Hits         2188     2206      +18     
+ Misses       2478     2468      -10     
- Partials      224      226       +2
Impacted Files Coverage Δ
pkg/skaffold/build/local/bazel.go 36.73% <45.45%> (+36.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9eb0dfc...8bd6fce. Read the comment docs.

Fix GoogleContainerTools#1339

Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
@dgageot dgageot merged commit 04431e2 into GoogleContainerTools:master Nov 30, 2018
@dgageot dgageot deleted the fix-1319 branch December 28, 2018 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants