Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bazel query should specify --output #1339

Closed
wants to merge 1 commit into from

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Nov 30, 2018

Fixes #1322

Signed-off-by: David Gageot david@gageot.net

@codecov-io
Copy link

codecov-io commented Nov 30, 2018

Codecov Report

Merging #1339 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1339   +/-   ##
=======================================
  Coverage   44.74%   44.74%           
=======================================
  Files         114      114           
  Lines        4890     4890           
=======================================
  Hits         2188     2188           
  Misses       2478     2478           
  Partials      224      224
Impacted Files Coverage Δ
pkg/skaffold/bazel/bazel.go 91.66% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9eb0dfc...b168f15. Read the comment docs.

dgageot added a commit to dgageot/skaffold that referenced this pull request Nov 30, 2018
Fix GoogleContainerTools#1339

Signed-off-by: David Gageot <david@gageot.net>
dgageot added a commit to dgageot/skaffold that referenced this pull request Nov 30, 2018
Fix GoogleContainerTools#1339

Signed-off-by: David Gageot <david@gageot.net>
Fixes GoogleContainerTools#1322

Signed-off-by: David Gageot <david@gageot.net>
Copy link
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants