Unify Jib command wrapper usage #1105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briandealwis
requested review from
balopat,
dgageot,
nkubala and
r2d4
as code owners
Codecov Report
@@ Coverage Diff @@
## jib_skaffold #1105 +/- ##
================================================
+ Coverage 42.94% 43.37% +0.42%
================================================
Files 82 78 -4
Lines 3600 3341 -259
================================================
- Hits 1546 1449 -97
+ Misses 1912 1759 -153
+ Partials 142 133 -9
Continue to review full report at Codecov.
|
11 tasks
dgageot
approved these changes
Oct 8, 2018
coollog
reviewed
Oct 8, 2018
| }, | ||
| }, | ||
| { | ||
| description: "gradle with wrapper", | ||
| jibGradleArtifact: latest.JibGradleArtifact{}, | ||
| filesInWorkspace: []string{getWrapperGradle()}, | ||
| filesInWorkspace: []string{"gradle", "gradle.cmd"}, |
There was a problem hiding this comment.
Is this supposed to be gradlew? Maybe these tests should check the command uses the wrapper?
coollog
reviewed
Oct 8, 2018
| func (cw CommandWrapper) CreateCommand(ctx context.Context, workingDir string, args []string) *exec.Cmd { | ||
| executable := cw.Executable | ||
|
|
||
| if cw.Wrapper != "" && !SkipWrapperCheck { |
There was a problem hiding this comment.
I noticed SkipWrapperCheck is always false - was this intentional?
There was a problem hiding this comment.
For tests. I should use that in #1152's tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a new
CommandWrapperstructure to specify the executable and wrapper names. Command lines are generated by aCommandWrapper#CreateCommand()method. I found examples of Maven having a .bat and .cmd wrappers, so we leave the extension determining to theCreateCommand()method.The builder codepath passes along a context, but the dependency-tracking codepath does not (#1104) so I pass along a dummy context for now.