Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SkaffoldRunner Dev should pass along its context #1104

Closed
briandealwis opened this issue Oct 5, 2018 · 0 comments
Closed

SkaffoldRunner Dev should pass along its context #1104

briandealwis opened this issue Oct 5, 2018 · 0 comments
Assignees
@dgageot
Labels
kind/feature-request

Comments

@briandealwis
Copy link
Member

SkaffoldRunner#Dev creates a watcher and registers artifact watchers via dependenciesForArtifact(), and should pass along its context.
@briandealwis briandealwis mentioned this issue Oct 5, 2018
Merged
@dgageot dgageot self-assigned this Oct 8, 2018
dgageot added a commit to dgageot/skaffold that referenced this issue Oct 8, 2018
@dgageot
Pass context when listing dependencies
d80959f 
Fixes GoogleContainerTools#1104
@dgageot dgageot mentioned this issue Oct 8, 2018
Merged
dgageot added a commit to dgageot/skaffold that referenced this issue Oct 9, 2018
@dgageot
Pass context when listing dependencies
53728f5 
Fixes GoogleContainerTools#1104
dgageot added a commit to dgageot/skaffold that referenced this issue Oct 9, 2018
@dgageot
Pass context when listing dependencies
f06f8f4 
Fixes GoogleContainerTools#1104
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dgageot dgageot

Labels
kind/feature-request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dgageot @briandealwis