Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use minikube image load for containerd #5773

Open
medyagh opened this issue May 3, 2021 · 4 comments
Open

use minikube image load for containerd #5773

medyagh opened this issue May 3, 2021 · 4 comments
Labels

Comments

@medyagh
Copy link
Member

medyagh commented May 3, 2021

No description provided.

@aaron-prindle
Copy link
Contributor

aaron-prindle commented May 4, 2021

From reading through the linked minikube issue information this is what I understand to be the tasks and verification required here:

Please feel free to add to the bug here w/ any tasks, files-to-touch and validation requirements if something here is incorrect/missing, thanks!

@aaron-prindle
Copy link
Contributor

aaron-prindle commented May 4, 2021

Is this related to the work required for #5739? Would it make sense to put this information as a task there if so? (and mark this as dupe)

@afbjorklund
Copy link

afbjorklund commented Aug 14, 2021

This solution would be needed, if wanting to load an image from the local docker daemon without using a registry...

minikube image build (#5739) is used, when wanting to transform a local "build context" (Dockerfile and friends)
i.e. same as docker build, but also for containerd and cri-o. this would perform the build in the minikube cluster

minikube image load (#5773) is used, when wanting to import a local tarball (with the manifest and the layers, etc)
i.e. same as docker load, but also for containerd and cri-o. this would have performed the build outside the cluster

It would make sense to have a "minikube" builder, same as the current "docker" builder (which doesn't support containerd)

Container Runtime Docker support Minikube support
docker yes yes (docker)
cri-o yes, with manual steps yes (podman)
containerd no yes (ctr/buildctl)

At the moment, the "custom build script" is also hard-coded to docker

@aaron-prindle aaron-prindle added this to the v1.33.0 milestone Sep 23, 2021
@aaron-prindle aaron-prindle self-assigned this Sep 23, 2021
@aaron-prindle aaron-prindle removed this from the v1.33.0 milestone Sep 27, 2021
@aaron-prindle
Copy link
Contributor

minikube image support has been removed from the 1.33 milestone and is currently not prioritized in the skaffold roadmap in the near term

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants