Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use container-runtime info from minikube node for image loading strategy #3711

Closed
balopat opened this issue Feb 20, 2020 · 2 comments
Closed
Labels
area/deploy kind/feature-request platform/minikube priority/awaiting-more-evidence Lowest Priority. May be useful, but there is not yet enough supporting evidence.

Comments

@balopat
Copy link
Contributor

balopat commented Feb 20, 2020

kubectl describe node contains the Container Runtime Version:

  Container Runtime Version:  docker://18.9.7

We should use this info to determine whether to build a docker image directly against the internal docker daemon determined by docker-env or by using minikube cache add (similar to kind load)

@dgageot
Copy link
Contributor

dgageot commented Jul 1, 2020

@balopat @tstromberg could you tell us how minikube cache add would be required or better?

@dgageot dgageot added the priority/awaiting-more-evidence Lowest Priority. May be useful, but there is not yet enough supporting evidence. label Jul 1, 2020
@nkubala nkubala added this to the Backlog [P0/P1] milestone Sep 1, 2020
@nkubala nkubala removed this from the Backlog [P0/P1] milestone May 11, 2021
@tejal29 tejal29 removed the priority/p1 High impact feature/bug. label Jul 1, 2021
@tejal29
Copy link
Contributor

tejal29 commented Jul 1, 2021

dupe of #5773

@tejal29 tejal29 closed this as completed Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/deploy kind/feature-request platform/minikube priority/awaiting-more-evidence Lowest Priority. May be useful, but there is not yet enough supporting evidence.
Projects
None yet
Development

No branches or pull requests

4 participants