Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix home and group set for user command #995

Merged
merged 1 commit into from
Jan 25, 2020

Conversation

tejal29
Copy link
Member

@tejal29 tejal29 commented Jan 23, 2020

Fixes #507

Description
In this PR,

  • If group string is not specified in USER command, it is set to user.
  • Move addDefaultHOME call after config.User is parsed and group is separated.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Reviewer Notes

  • The code flow looks good.
  • Unit tests and or integration tests added.

Release Notes

Describe any changes here so maintainer can include it in the release notes, or delete this block.

GID now defaults to UID if not set for USER command
HOME is set correctly when group string present in USER command e.g. `USER user:grp` 

@googlebot googlebot added the cla: yes CLA signed by all commit authors label Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
candidate-release cla: yes CLA signed by all commit authors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

USER command set wrong $HOME or gid
3 participants