fix user metadata set to USER:GROUP if group string is not set #1105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
tejal29
force-pushed
the
fix_user_metadata
branch
from
fad9fb0
to
c1e3f42
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #824 and #995
Should merge before #1072
In this PR, remove
config.Userstring being set toUSER:GROUPwhen group is not specified.This is in line with docker behavior. See details
This change will not affect group Id not being set on files because.
When executing
RunCommand,Executor calls the method
util.GetUIDAndGIDFromStringwithfallback = trueThis method will evaluate the user string. The string previously passed was "testuser:testgrp"
Now with this change, the string will be just "testuser"
The method
util.GetUIDAndGIDFromStringwill now fallback touser.GidhereFollow up clean up PR: We can safely remove
fallbackfrom theutil.GetUIDAndGIDFromStringsignature since this value is always true.