Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add integration test for add url with arg #863

Merged
merged 1 commit into from
Nov 18, 2019
Merged

Add integration test for add url with arg #863

merged 1 commit into from
Nov 18, 2019

Conversation

cvgw
Copy link
Contributor

@cvgw cvgw commented Nov 15, 2019 •
edited
Loading

Description

Adds integration test to cover gap identified by #431

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes unit tests
  • Adds integration tests if needed.

See the contribution guide for more details.

Reviewer Notes

  • The code flow looks good.
  • Unit tests and or integration tests added.

Release Notes

priyawadhwa
priyawadhwa approved these changes Nov 18, 2019
View reviewed changes
Copy link
Collaborator

@priyawadhwa priyawadhwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@priyawadhwa priyawadhwa merged commit e0e59e6 into GoogleContainerTools:master Nov 18, 2019
@cvgw cvgw deleted the u/cvgw/add_env_variables branch November 18, 2019 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@priyawadhwa priyawadhwa priyawadhwa approved these changes

@tejal29 tejal29 Awaiting requested review from tejal29

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cvgw @priyawadhwa