Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADD does not support ENV/ADD variables #431

Closed
morsik opened this issue Nov 5, 2018 · 2 comments
Closed

ADD does not support ENV/ADD variables #431

morsik opened this issue Nov 5, 2018 · 2 comments
Labels
area/dockerfile-command For all bugs related to dockerfile file commands cmd/add help wanted Looking for a volunteer! kind/feature-request norepro core team can't replicate this issue, require more info priority/p1 Basic need feature compatibility with docker build. we should be working on this next.

Comments

@morsik
Copy link

morsik commented Nov 5, 2018

Actual behavior
ADD should support variables defined in ENV/ADD like RUN does, and like Docker does.

Example that works in docker build but doesn't work with kaniko:

ARG OC_VERSION=v3.11.0
ARG OC_RELEASE=openshift-origin-client-tools-v3.11.0-0cbc58b-linux-64bit

ADD https://github.com/openshift/origin/releases/download/$OC_VERSION/$OC_RELEASE.tar.gz /tmp/release.tar.gz

But this works:

ARG OC_VERSION=v3.11.0
ARG OC_RELEASE=openshift-origin-client-tools-v3.11.0-0cbc58b-linux-64bit

RUN wget https://github.com/openshift/origin/releases/download/$OC_VERSION/$OC_RELEASE.tar.gz -O /tmp/release.tar.gz

Expected behavior
Kaniko should build this like Docker does.

To Reproduce
Use examples above ;)

Additional Information

  • Kaniko Image: gcr.io/kaniko-project/executor:debug@f1c17ecce552018e5acb88591c9c17ad606af12473f2837d25cbb815c1308880
@tequilarista tequilarista added the help wanted Looking for a volunteer! label Jul 30, 2019
@donmccasland donmccasland added area/dockerfile-command For all bugs related to dockerfile file commands priority/p1 Basic need feature compatibility with docker build. we should be working on this next. labels Sep 24, 2019
@cvgw cvgw added the norepro core team can't replicate this issue, require more info label Nov 15, 2019
@cvgw
Copy link
Contributor

cvgw commented Nov 15, 2019

@morsik I am unable to repro this issue. Looks like it may have since been fixed. Can you please confirm whether it is still happening on your end. Thanks!

@morsik
Copy link
Author

morsik commented Apr 17, 2021

@cvgw yes, it was fixed somewhere along the way! Thanks :D

(sorry, I had to reply on this old one since you replied 1 year later too and it's just funny :P)

@morsik morsik closed this as completed Apr 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dockerfile-command For all bugs related to dockerfile file commands cmd/add help wanted Looking for a volunteer! kind/feature-request norepro core team can't replicate this issue, require more info priority/p1 Basic need feature compatibility with docker build. we should be working on this next.
Projects
None yet
Development

No branches or pull requests

5 participants