Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add separator functionality to variable modification directives #704

Merged

Conversation

douglasjacobsen
Copy link
Collaborator

This merge allows variable_modification directives to define a separator attribute that can be used when the method of modification is append or prepend.

@douglasjacobsen douglasjacobsen added the enhancement New feature or request label Oct 17, 2024
linsword13
linsword13 previously approved these changes Oct 18, 2024
linsword13
linsword13 previously approved these changes Oct 18, 2024
@linsword13
Copy link
Collaborator

Reminder for resolving the merge conflict.

This commit adds the ability for variable modification directives to
define the separator between their modification value and the previous
value.

This argument is only used when the method is `append` or `prepend.
@douglasjacobsen
Copy link
Collaborator Author

OK, should be resolved now. Thanks

@rfbgo rfbgo merged commit 753c5e5 into GoogleCloudPlatform:develop Oct 23, 2024
12 checks passed
@douglasjacobsen douglasjacobsen deleted the variable-mod-separator branch November 8, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants