Add separator to existing modifier definitions

GoogleCloudPlatform · Oct 18, 2024 · a44801c · a44801c
1 parent 0d1344a
commit a44801c
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 4 deletions.
diff --git a/var/ramble/repos/builtin.mock/modifiers/test-mod-2/modifier.py b/var/ramble/repos/builtin.mock/modifiers/test-mod-2/modifier.py
@@ -25,7 +25,7 @@ class TestMod2(BasicModifier):
 
     variable_modification(
         "test_var_mod",
-        " test-mod-2-append",
+        "test-mod-2-append",
         method="append",
         modes=["test"],
     )
diff --git a/var/ramble/repos/builtin.mock/modifiers/test-mod/modifier.py b/var/ramble/repos/builtin.mock/modifiers/test-mod/modifier.py
@@ -34,14 +34,14 @@ class TestMod(BasicModifier):
 
     variable_modification(
         "test_var_mod",
-        " test-mod-append",
+        "test-mod-append",
         method="append",
         modes=["test"],
     )
 
     variable_modification(
         "mpi_command",
-        'echo "prefix_mpi_command" >> {log_file}; ',
+        'echo "prefix_mpi_command" >> {log_file};',
         method="prepend",
         modes=["test"],
     )

diff --git a/var/ramble/repos/builtin/modifiers/intel-aps/modifier.py b/var/ramble/repos/builtin/modifiers/intel-aps/modifier.py
@@ -54,7 +54,7 @@ class IntelAps(BasicModifier):
         "aps_flags", "-c mpi -r {aps_log_dir}", method="set", modes=["mpi"]
     )
     variable_modification(
-        "mpi_command", " aps {aps_flags} ", method="append", modes=["mpi"]
+        "mpi_command", "aps {aps_flags} ", method="append", modes=["mpi"]
     )
 
     modifier_variable(

diff --git a/var/ramble/repos/builtin/modifiers/pyxis-enroot/modifier.py b/var/ramble/repos/builtin/modifiers/pyxis-enroot/modifier.py
@@ -191,6 +191,7 @@ def extract_names(itr, name_set=set()):
                         "container_mounts",
                         modification=prefix + exp_mount,
                         method="append",
+                        separator=",",
                         mode=self._usage_mode,
                     )