Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure spack install dir based on env_name #495

Merged
merged 1 commit into from
May 20, 2024

Conversation

linsword13
Copy link
Collaborator

@linsword13 linsword13 commented May 18, 2024

Configure spack install dir based on env_name

This helps with saving redundant spack concretization, when experiments
under different workloads are actually using the same software environment.

Some more contexts (courtesy of Bob and Doug):

Tested: tested with the following:

  • A new created workspace with gromacs ran fine.

  • (backward-compt) An existing workspace created from the current
    develop head ran fine after running ramble workspace setup under the
    current branch.

@linsword13 linsword13 force-pushed the spack-cache branch 4 times, most recently from 582a2ed to 6e737c8 Compare May 20, 2024 20:59
@linsword13 linsword13 marked this pull request as ready for review May 20, 2024 21:00
This helps with saving redundant spack concretization, when experiments
under different workloads are actually using the same software environment.

Some more contexts (courtesy of Bob and Doug):

* Historically the spack env was rendered during workspace render time,
  that's why the existing namespacing.

* That's changed in
  GoogleCloudPlatform#433.

* And it's safe to assume same `env_name` always 1-1 maps to a spack
  env. There's a check to guarantee that:
  https://github.com/GoogleCloudPlatform/ramble/blob/f4e0e06c7f4ab0efd5d05000cb7ebec7b3ad33b2/lib/ramble/ramble/software_environments.py#L371-L374.

Tested: tested with the following:

* A new created workspace with gromacs ran fine.

* (backward-compt) An existing workspace created from the current
  develop head ran fine after running `ramble workspace setup` under the
  current branch.
@douglasjacobsen douglasjacobsen merged commit 9aa2800 into GoogleCloudPlatform:develop May 20, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants