Convert environment generation logic to lazy / implcit instead of explicit #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
douglasjacobsen
added
documentation
douglasjacobsen
force-pushed
the
exp_specific_envs
branch
3 times, most recently
from
1fc88c4 to
3999010
Compare
This commit updates the way software environments are generated. Previously, software environments were required to be explicitly defined in the workspace configuration file. This raised some problems relating to the vector / matrix logic being unable to process vectors that didn't actually impact the software environments. This commit changes the behavior to cause experiments to render their own software environments based on their variable definitions. This prevents the previously mention issue by presenting only scalar variable definitions to the software environment.
douglasjacobsen
force-pushed
the
exp_specific_envs
branch
from
3999010 to
2f15219
Compare
rfbgo
previously approved these changes
Mar 7, 2024
douglasjacobsen
force-pushed
the
exp_specific_envs
branch
from
c50a908 to
1e72c7d
Compare
rfbgo
approved these changes
Mar 7, 2024
linsword13
added a commit
to linsword13/ramble
that referenced
this pull request
May 20, 2024
This helps with saving redundant spack concretization, when experiments under different workloads are actually using the same software environment. Some more contexts (courtesy of Bob and Doug): * Historically the spack env was rendered during workspace render time, that's why the existing namespacing. * That's changed in GoogleCloudPlatform#433. * And it's safe to assume same `env_name` always 1-1 maps to a spack env. There's a check to guarantee that: https://github.com/GoogleCloudPlatform/ramble/blob/f4e0e06c7f4ab0efd5d05000cb7ebec7b3ad33b2/lib/ramble/ramble/software_environments.py#L371-L374. Tested: tested with the following: * A new created workspace with gromacs ran fine. * (backward-compt) An existing workspace created from the current develop head ran fine after running `ramble workspace setup` under the current branch.
linsword13
added a commit
to linsword13/ramble
that referenced
this pull request
May 20, 2024
This helps with saving redundant spack concretization, when experiments under different workloads are actually using the same software environment. Some more contexts (courtesy of Bob and Doug): * Historically the spack env was rendered during workspace render time, that's why the existing namespacing. * That's changed in GoogleCloudPlatform#433. * And it's safe to assume same `env_name` always 1-1 maps to a spack env. There's a check to guarantee that: https://github.com/GoogleCloudPlatform/ramble/blob/f4e0e06c7f4ab0efd5d05000cb7ebec7b3ad33b2/lib/ramble/ramble/software_environments.py#L371-L374. Tested: tested with the following: * A new created workspace with gromacs ran fine. * (backward-compt) An existing workspace created from the current develop head ran fine after running `ramble workspace setup` under the current branch.
linsword13
added a commit
to linsword13/ramble
that referenced
this pull request
May 20, 2024
This helps with saving redundant spack concretization, when experiments under different workloads are actually using the same software environment. Some more contexts (courtesy of Bob and Doug): * Historically the spack env was rendered during workspace render time, that's why the existing namespacing. * That's changed in GoogleCloudPlatform#433. * And it's safe to assume same `env_name` always 1-1 maps to a spack env. There's a check to guarantee that: https://github.com/GoogleCloudPlatform/ramble/blob/f4e0e06c7f4ab0efd5d05000cb7ebec7b3ad33b2/lib/ramble/ramble/software_environments.py#L371-L374. Tested: tested with the following: * A new created workspace with gromacs ran fine. * (backward-compt) An existing workspace created from the current develop head ran fine after running `ramble workspace setup` under the current branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge converts the logic around generating software environments and packages away from being explicitly defined in the workspace configuration file.
Instead, packages and environments are now generated lazily when processing experiments. This avoids several issues related to vector / matrix logic causing problems rendering individual packages and environments.