Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OTel dependency to v1.14.0/v0.37.0 #616

Merged
merged 2 commits into from
Mar 20, 2023

Conversation

zchee
Copy link
Contributor

@zchee zchee commented Mar 19, 2023

Update each OTel dependency to v1.14.0/v0.37.0, and format go.mod.
Note that upgrade collector, and each contrib package are based v1.14.0/v0.37.0.

Release note:

Also, remove use the deprecated (removed) go.opentelemetry.io/otel/metric/unit package, and unified semconv version with v1.18.0.

  • go.opentelemetry.io/otel@v1.14.0
  • go.opentelemetry.io/otel/metric@v0.37.0
  • go.opentelemetry.io/otel/metric/instrument@v1.14.0
  • go.opentelemetry.io/otel/sdk@v1.14.0
  • go.opentelemetry.io/otel/sdk/export/metric@v0.37.0
  • go.opentelemetry.io/otel/sdk/metric@v0.37.0
  • go.opentelemetry.io/otel/trace@v1.15.0
  • go.opentelemetry.io/otel/exporters/prometheus@v0.37.0
  • go.opentelemetry.io/contrib/detectors/gcp@v1.15.0
  • go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp@v0.40.0
  • go.opentelemetry.io/collector@v0.73.0
  • go.opentelemetry.io/collector/featuregate@v0.73.0
  • go.opentelemetry.io/collector/semconv@v0.73.0
  • go.opentelemetry.io/collector/pdata@v1.0.0-rc7
  • github.com/open-telemetry/opentelemetry-collector-contrib/pkg/translator/prometheus@v0.73.0

Close: #611

@codecov
Copy link

codecov bot commented Mar 19, 2023

Codecov Report

Merging #616 (8aa0411) into main (7589f5b) will decrease coverage by 0.17%.
The diff coverage is 33.33%.

❗ Current head 8aa0411 differs from pull request most recent head 73f4f60. Consider uploading reports for the commit 73f4f60 to get more accurate results

@@            Coverage Diff             @@
##             main     #616      +/-   ##
==========================================
- Coverage   63.55%   63.38%   -0.17%     
==========================================
  Files          38       38              
  Lines        4409     4408       -1     
==========================================
- Hits         2802     2794       -8     
- Misses       1483     1490       +7     
  Partials      124      124              
Impacted Files Coverage Δ
exporter/metric/option.go 64.70% <ø> (ø)
exporter/trace/trace_proto.go 65.00% <0.00%> (+0.26%) ⬆️
.../collector/integrationtest/testcases/conversion.go 76.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@zchee zchee marked this pull request as ready for review March 19, 2023 21:54
@zchee zchee requested a review from a team as a code owner March 19, 2023 21:54
@zchee zchee force-pushed the otel-v1.14.0-v0.37.0 branch from b1e2793 to 77d320a Compare March 19, 2023 22:02
@damemi damemi self-assigned this Mar 20, 2023
@damemi
Copy link
Contributor

damemi commented Mar 20, 2023

/gcbrun

@zchee
Copy link
Contributor Author

zchee commented Mar 20, 2023

@damemi
Note that this changes needs to edit branch protection with remove compatibility-test (1.18, XXX).

Copy link
Contributor

@damemi damemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for understanding @zchee, I think this is a good incremental change. just 1 whitespace question. I'll check the branch protection rules. Might just have to override those when I merge, then I'll remove them once I can verify that the 1.20 compatibility tests run in the next PR

Makefile Outdated
Comment on lines 188 to 194
STABLE_OTEL_VERSION=v1.14.0
UNSTABLE_OTEL_VERSION=v0.37.0
STABLE_CONTRIB_OTEL_VERSION=v1.15.0
UNSTABLE_CONTRIB_OTEL_VERSION=v0.40.0
STABLE_CONTRIB_OTEL_VERSION=v1.15.0
UNSTABLE_COLLECTOR_VERSION=v0.72.0
STABLE_COLLECTOR_VERSION=v1.0.0-rc6
UNSTABLE_COLLECTOR_CONTRIB_VERSION=v0.72.0
STABLE_COLLECTOR_VERSION=v1.0.0-rc7
UNSTABLE_COLLECTOR_VERSION=v0.73.0
UNSTABLE_COLLECTOR_CONTRIB_VERSION=v0.73.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are the spaces at the start of these lines intentional?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@damemi
ah, removed and force pushed.

zchee added 2 commits March 21, 2023 05:20
Update each OTel dependency to v1.14.0/v0.37.0, and format go.mod.
Also, remove deprecated (removed) go.otel/metric/unit package
and unified semconv version with v1.18.0.

- go.opentelemetry.io/otel@v1.14.0
- go.opentelemetry.io/otel/metric@v0.37.0
- go.opentelemetry.io/otel/metric/instrument@v1.14.0
- go.opentelemetry.io/otel/sdk@v1.14.0
- go.opentelemetry.io/otel/sdk/export/metric@v0.37.0
- go.opentelemetry.io/otel/sdk/metric@v0.37.0
- go.opentelemetry.io/otel/trace@v1.15.0
- go.opentelemetry.io/otel/exporters/prometheus@v0.37.0
- go.opentelemetry.io/contrib/detectors/gcp@v1.15.0
- go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp@v0.40.0
- go.opentelemetry.io/collector@v0.73.0
- go.opentelemetry.io/collector/featuregate@v0.73.0
- go.opentelemetry.io/collector/semconv@v0.73.0
- go.opentelemetry.io/collector/pdata@v1.0.0-rc7
- github.com/open-telemetry/opentelemetry-collector-contrib/pkg/translator/prometheus@v0.73.0

Signed-off-by: Koichi Shiraishi <zchee.io@gmail.com>
Signed-off-by: Koichi Shiraishi <zchee.io@gmail.com>
@zchee zchee force-pushed the otel-v1.14.0-v0.37.0 branch from 77d320a to 73f4f60 Compare March 20, 2023 20:21
@zchee
Copy link
Contributor Author

zchee commented Mar 20, 2023

@damemi PTAL

@damemi damemi closed this Mar 20, 2023
@damemi damemi reopened this Mar 20, 2023
@damemi
Copy link
Contributor

damemi commented Mar 20, 2023

/gcbrun

@damemi damemi closed this Mar 20, 2023
@damemi damemi reopened this Mar 20, 2023
@damemi
Copy link
Contributor

damemi commented Mar 20, 2023

Sorry for the spam, closed and reopened to see if the new branch protection took effect

@damemi
Copy link
Contributor

damemi commented Mar 20, 2023

/gcbrun

@damemi damemi merged commit c3f1a10 into GoogleCloudPlatform:main Mar 20, 2023
@zchee zchee deleted the otel-v1.14.0-v0.37.0 branch March 20, 2023 21:12
@zchee
Copy link
Contributor Author

zchee commented Mar 20, 2023

@damemi thanks!

@damemi
Copy link
Contributor

damemi commented Mar 20, 2023

@zchee Thanks for your patience!

@zchee
Copy link
Contributor Author

zchee commented Mar 20, 2023

@damemi BTW, are you planned cut new release include this changes?

@damemi
Copy link
Contributor

damemi commented Mar 20, 2023

@zchee yeah we can do a release with these libraries then another once the SDK libraries are GA

@zchee
Copy link
Contributor Author

zchee commented Mar 20, 2023

@damemi Ah, I mean, are you planned create "v0.37.0 and v1.13.0" (or etc)? Because upgraded each OTel dependency, also "update go version to 1.20" is worth to new version.

@damemi
Copy link
Contributor

damemi commented Mar 21, 2023

@zchee yup that's what I meant, sorry

@zchee
Copy link
Contributor Author

zchee commented Mar 22, 2023

@damemi Ah thanks! sorry for misreading cuz I'm not good English :P
I can't wait to cut new release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants