-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update OTel dependency to v1.14.0/v0.37.0 #616
Conversation
Codecov Report
@@ Coverage Diff @@
## main #616 +/- ##
==========================================
- Coverage 63.55% 63.38% -0.17%
==========================================
Files 38 38
Lines 4409 4408 -1
==========================================
- Hits 2802 2794 -8
- Misses 1483 1490 +7
Partials 124 124
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
b1e2793
to
77d320a
Compare
/gcbrun |
@damemi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for understanding @zchee, I think this is a good incremental change. just 1 whitespace question. I'll check the branch protection rules. Might just have to override those when I merge, then I'll remove them once I can verify that the 1.20 compatibility tests run in the next PR
Makefile
Outdated
STABLE_OTEL_VERSION=v1.14.0 | ||
UNSTABLE_OTEL_VERSION=v0.37.0 | ||
STABLE_CONTRIB_OTEL_VERSION=v1.15.0 | ||
UNSTABLE_CONTRIB_OTEL_VERSION=v0.40.0 | ||
STABLE_CONTRIB_OTEL_VERSION=v1.15.0 | ||
UNSTABLE_COLLECTOR_VERSION=v0.72.0 | ||
STABLE_COLLECTOR_VERSION=v1.0.0-rc6 | ||
UNSTABLE_COLLECTOR_CONTRIB_VERSION=v0.72.0 | ||
STABLE_COLLECTOR_VERSION=v1.0.0-rc7 | ||
UNSTABLE_COLLECTOR_VERSION=v0.73.0 | ||
UNSTABLE_COLLECTOR_CONTRIB_VERSION=v0.73.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are the spaces at the start of these lines intentional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@damemi
ah, removed and force pushed.
Update each OTel dependency to v1.14.0/v0.37.0, and format go.mod. Also, remove deprecated (removed) go.otel/metric/unit package and unified semconv version with v1.18.0. - go.opentelemetry.io/otel@v1.14.0 - go.opentelemetry.io/otel/metric@v0.37.0 - go.opentelemetry.io/otel/metric/instrument@v1.14.0 - go.opentelemetry.io/otel/sdk@v1.14.0 - go.opentelemetry.io/otel/sdk/export/metric@v0.37.0 - go.opentelemetry.io/otel/sdk/metric@v0.37.0 - go.opentelemetry.io/otel/trace@v1.15.0 - go.opentelemetry.io/otel/exporters/prometheus@v0.37.0 - go.opentelemetry.io/contrib/detectors/gcp@v1.15.0 - go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp@v0.40.0 - go.opentelemetry.io/collector@v0.73.0 - go.opentelemetry.io/collector/featuregate@v0.73.0 - go.opentelemetry.io/collector/semconv@v0.73.0 - go.opentelemetry.io/collector/pdata@v1.0.0-rc7 - github.com/open-telemetry/opentelemetry-collector-contrib/pkg/translator/prometheus@v0.73.0 Signed-off-by: Koichi Shiraishi <zchee.io@gmail.com>
Signed-off-by: Koichi Shiraishi <zchee.io@gmail.com>
77d320a
to
73f4f60
Compare
@damemi PTAL |
/gcbrun |
Sorry for the spam, closed and reopened to see if the new branch protection took effect |
/gcbrun |
@damemi thanks! |
@zchee Thanks for your patience! |
@damemi BTW, are you planned cut new release include this changes? |
@zchee yeah we can do a release with these libraries then another once the SDK libraries are GA |
@damemi Ah, I mean, are you planned create "v0.37.0 and v1.13.0" (or etc)? Because upgraded each OTel dependency, also "update go version to 1.20" is worth to new version. |
@zchee yup that's what I meant, sorry |
@damemi Ah thanks! sorry for misreading cuz I'm not good English :P |
Update each OTel dependency to v1.14.0/v0.37.0, and format
go.mod
.Note that upgrade collector, and each contrib package are based v1.14.0/v0.37.0.
Release note:
Also, remove use the deprecated (removed)
go.opentelemetry.io/otel/metric/unit
package, and unified semconv version withv1.18.0
.Close: #611