Update OTel dependency to v1.15.0-rc.1/v0.38.0-rc.1 #611

zchee · 2023-03-10T04:49:33Z

Update each OTel dependency to v1.15.0-rc.1/v0.38.0-rc.1 and format go.mod.

Also, remove the deprecated (removed) go.opentelemetry.io/otel/metric/unit package and unified semconv version with v1.18.0.

codecov · 2023-03-10T04:58:49Z

Codecov Report

Merging #611 (2b301aa) into main (7589f5b) will increase coverage by 2.59%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##             main     #611      +/-   ##
==========================================
+ Coverage   63.55%   66.14%   +2.59%     
==========================================
  Files          38       36       -2     
  Lines        4409     4224     -185     
==========================================
- Hits         2802     2794       -8     
+ Misses       1483     1306     -177     
  Partials      124      124

Impacted Files	Coverage Δ
exporter/metric/option.go	`64.70% <ø> (ø)`
exporter/trace/trace_proto.go	`65.00% <0.00%> (+0.26%)`	⬆️
.../collector/integrationtest/testcases/conversion.go	`76.00% <100.00%> (ø)`

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

zchee · 2023-03-10T05:08:08Z

Drop Go 1.18 because otelcol changed to use sync/atomic instead of go.uber.org/atomic.

If you accept this, I'll squash the below commit:

Update DEFAULT_GO_VERSION to 1.20 and drop 1.18 on compatibility-test

zchee · 2023-03-10T05:15:02Z

Failed lint job because doesn't support current golangci-lint to go1.20. So update to v1.51.2.
Will squash Update golangci/golangci-lint to v1.51.2 for go1.20 and fix lint issues as well, if you accept drop go1.18.

damemi · 2023-03-10T14:17:48Z

/gcbrun

zchee · 2023-03-10T15:10:23Z

@damemi Seems passed all tests. Should I squash?

damemi · 2023-03-10T15:13:15Z

Makefile

+  STABLE_OTEL_VERSION=v1.15.0-rc.1
+UNSTABLE_OTEL_VERSION=v0.38.0-rc.1
+  STABLE_CONTRIB_OTEL_VERSION=v1.16.0-rc.1
+UNSTABLE_CONTRIB_OTEL_VERSION=v0.41.0-rc.1
+  STABLE_COLLECTOR_VERSION=v1.0.0-rc7


instead of bumping to rc tags now, would it be worth just waiting for the GA tags of each of these?

@damemi follow your opinion. However, I will continue to send PRs to follow upstream.

damemi · 2023-03-10T15:13:33Z

.github/workflows/ci.yml

@@ -8,7 +8,7 @@ env:
  # Path to where test results will be saved.
  TEST_RESULTS: /tmp/test-results
  # Default minimum version of Go to support.
-  DEFAULT_GO_VERSION: 1.19
+  DEFAULT_GO_VERSION: "1.20"


should we update our go.mod files to 1.20 as well?

zchee · 2023-03-14T05:53:33Z

@damemi PTAL

zchee · 2023-03-14T06:01:17Z

example/metric/example.go

@@ -109,14 +109,13 @@ func main() {

 	// Add measurement once an every 10 second.
 	timer := time.NewTicker(10 * time.Second)
+	rng := rand.New(rand.NewSource(time.Now().UnixNano()))


lint issue on go1.20

damemi · 2023-03-15T14:00:25Z

/gcbrun

zchee · 2023-03-15T14:45:27Z

@damemi I'll fix conflicts

damemi · 2023-03-15T17:39:23Z

@damemi I'll fix conflicts

sorry @zchee, I caused those conflicts because I wanted to get at least 1 release published on go 1.19 before moving forward with this (instead of jumping from 1.18->1.20 in one release).

I'm still not sure about the rc tags, and would rather not publish a release based on those if possible. Are these updates urgent?

Update each OTel dependency, and format go.mod. Also, remove deprecated (removed) go.otel/metric/unit package and unified semconv version with v1.18.0. - go.opentelemetry.io/otel@v1.15.0-rc.1 - go.opentelemetry.io/otel/metric@v1.15.0-rc.1 - go.opentelemetry.io/otel/metric/instrument@v1.15.0-rc.1 - go.opentelemetry.io/otel/sdk@v1.15.0-rc.1 - go.opentelemetry.io/otel/sdk/export/metric@v0.38.0-rc.1 - go.opentelemetry.io/otel/sdk/metric@v0.38.0-rc.1 - go.opentelemetry.io/otel/trace@v1.15.0-rc.1 - go.opentelemetry.io/otel/exporters/prometheus@v0.38.0-rc.1 - go.opentelemetry.io/contrib/detectors/gcp@v1.16.0-rc.1 - go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp@v0.41.0-rc.1 - go.opentelemetry.io/collector@v0.73.0 - go.opentelemetry.io/collector/featuregate@v0.73.0 - go.opentelemetry.io/collector/semconv@v0.73.0 - go.opentelemetry.io/collector/pdata@v1.0.0-rc7 - github.com/open-telemetry/opentelemetry-collector-contrib/pkg/translator/prometheus@v0.73.0 Signed-off-by: Koichi Shiraishi <zchee.io@gmail.com>

Signed-off-by: Koichi Shiraishi <zchee.io@gmail.com>

zchee · 2023-03-19T21:52:37Z

@damemi

sorry @zchee, I caused those conflicts because I wanted to get at least 1 release published on go 1.19 before moving forward with this (instead of jumping from 1.18->1.20 in one release).

np, that I also thought makes sense.

I'm still not sure about the rc tags, and would rather not publish a release based on those if possible. Are these updates urgent?

Okay, I agree.
So how about updating to the previous version of opentelemetry-go RC version (v1.14.0/v0.37.0/v0.0.4) and waiting for it to become GA? As far as the release notes of v1.14.0/v0.37.0/v0.0.4 are concerned, it seems reasonable as an upgrade while waiting for the GA release.
Like #616.

zchee requested a review from a team as a code owner March 10, 2023 04:49

zchee force-pushed the otel-2023-03-10 branch from aa5785a to e45bebf Compare March 10, 2023 04:55

zchee force-pushed the otel-2023-03-10 branch from 7d9fff0 to 4c0af7b Compare March 10, 2023 05:08

zchee force-pushed the otel-2023-03-10 branch 2 times, most recently from 3c951d3 to 30e6ae4 Compare March 10, 2023 05:40

damemi self-assigned this Mar 10, 2023

damemi reviewed Mar 10, 2023

View reviewed changes

zchee force-pushed the otel-2023-03-10 branch from b8fce70 to 6de7055 Compare March 14, 2023 05:52

zchee requested a review from damemi March 14, 2023 05:53

zchee commented Mar 14, 2023

View reviewed changes

zchee force-pushed the otel-2023-03-10 branch from 6de7055 to b6a96c5 Compare March 14, 2023 06:04

zchee added 4 commits March 16, 2023 11:54

Update DEFAULT_GO_VERSION to 1.20 and drop 1.18 on compatibility-test

60ccbd3

Signed-off-by: Koichi Shiraishi <zchee.io@gmail.com>

Update golangci/golangci-lint to v1.51.2 for go1.20 and fix lint issues

c15b9b7

Signed-off-by: Koichi Shiraishi <zchee.io@gmail.com>

Update go version to 1.20

2b301aa

Signed-off-by: Koichi Shiraishi <zchee.io@gmail.com>

zchee force-pushed the otel-2023-03-10 branch from b6a96c5 to 2b301aa Compare March 16, 2023 02:54

zchee changed the title ~~Update OTel dependency~~ Update OTel dependency to v1.15.0-rc.1/v0.38.0-rc.1 Mar 19, 2023

zchee mentioned this pull request Mar 20, 2023

Update OTel dependency to v1.14.0/v0.37.0 #616

Merged

damemi closed this in #616 Mar 20, 2023

zchee deleted the otel-2023-03-10 branch March 20, 2023 21:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update OTel dependency to v1.15.0-rc.1/v0.38.0-rc.1 #611

Update OTel dependency to v1.15.0-rc.1/v0.38.0-rc.1 #611

zchee commented Mar 10, 2023 •

edited

Loading

codecov bot commented Mar 10, 2023 •

edited

Loading

zchee commented Mar 10, 2023 •

edited

Loading

zchee commented Mar 10, 2023 •

edited

Loading

damemi commented Mar 10, 2023

zchee commented Mar 10, 2023

damemi Mar 10, 2023

zchee Mar 14, 2023

damemi Mar 10, 2023

zchee Mar 14, 2023

zchee commented Mar 14, 2023

zchee Mar 14, 2023

damemi commented Mar 15, 2023

zchee commented Mar 15, 2023

damemi commented Mar 15, 2023

zchee commented Mar 19, 2023

Update OTel dependency to v1.15.0-rc.1/v0.38.0-rc.1 #611

Update OTel dependency to v1.15.0-rc.1/v0.38.0-rc.1 #611

Conversation

zchee commented Mar 10, 2023 • edited Loading

codecov bot commented Mar 10, 2023 • edited Loading

Codecov Report

zchee commented Mar 10, 2023 • edited Loading

zchee commented Mar 10, 2023 • edited Loading

damemi commented Mar 10, 2023

zchee commented Mar 10, 2023

damemi Mar 10, 2023

Choose a reason for hiding this comment

zchee Mar 14, 2023

Choose a reason for hiding this comment

damemi Mar 10, 2023

Choose a reason for hiding this comment

zchee Mar 14, 2023

Choose a reason for hiding this comment

zchee commented Mar 14, 2023

zchee Mar 14, 2023

Choose a reason for hiding this comment

damemi commented Mar 15, 2023

zchee commented Mar 15, 2023

damemi commented Mar 15, 2023

zchee commented Mar 19, 2023

zchee commented Mar 10, 2023 •

edited

Loading

codecov bot commented Mar 10, 2023 •

edited

Loading

zchee commented Mar 10, 2023 •

edited

Loading

zchee commented Mar 10, 2023 •

edited

Loading