Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Update test runner for Cloud Run logging-manual #2097

Merged
merged 2 commits into from
Dec 8, 2020
Merged

fix: Update test runner for Cloud Run logging-manual #2097

merged 2 commits into from
Dec 8, 2020

Conversation

averikitsch
Copy link
Contributor

@averikitsch averikitsch commented Dec 8, 2020 •
edited
Loading

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 8, 2020
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Dec 8, 2020
fhinkel
fhinkel approved these changes Dec 8, 2020
View reviewed changes
Copy link
Contributor

@fhinkel fhinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@fhinkel fhinkel merged commit 2eda771 into master Dec 8, 2020
@fhinkel fhinkel deleted the logging-manual-tests branch December 8, 2020 09:11
This was referenced Dec 8, 2020
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fhinkel fhinkel fhinkel approved these changes

@grayside grayside Awaiting requested review from grayside

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

run/logging-manual: reducing test failure noise
2 participants
@averikitsch @fhinkel