Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

run/logging-manual: retains "message" property for display text failed #2077

Closed
flaky-bot bot opened this issue Nov 19, 2020 · 3 comments
Closed

run/logging-manual: retains "message" property for display text failed #2077

flaky-bot bot opened this issue Nov 19, 2020 · 3 comments
Assignees
@averikitsch
Labels
api: run Issues related to the Cloud Run API. priority: p2 Moderately-important priority. Fix may not be included in next release. samples Issues that are directly related to samples. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@flaky-bot
Copy link

flaky-bot bot commented Nov 19, 2020

Note: #1952 was also for this test, but it was closed more than 10 days ago. So, I didn't mark it flaky.

commit: ffd9ad9
buildURL: Build Status, Sponge
status: failed

Test output
property found in the log entry
AssertionError [ERR_ASSERTION]: property found in the log entry
    at Context. (test/system.test.js:99:7)
    at processImmediate (internal/timers.js:456:21)
@flaky-bot flaky-bot bot added buildcop: issue priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Nov 19, 2020
@product-auto-label product-auto-label bot added api: run Issues related to the Cloud Run API. samples Issues that are directly related to samples. labels Nov 19, 2020
@flaky-bot
Copy link
Author

flaky-bot bot commented Nov 23, 2020

Looks like this issue is flaky. 😟

I'm going to leave this open and stop commenting.

A human should fix and close this.

When run at the same commit (ffd9ad9), this test passed in one build (Build Status, Sponge) and failed in another build (Build Status, Sponge).

1 similar comment
@flaky-bot
Copy link
Author

flaky-bot bot commented Nov 23, 2020

Looks like this issue is flaky. 😟

I'm going to leave this open and stop commenting.

A human should fix and close this.

When run at the same commit (ffd9ad9), this test passed in one build (Build Status, Sponge) and failed in another build (Build Status, Sponge).

@averikitsch averikitsch assigned averikitsch and unassigned grayside Nov 23, 2020
@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Nov 26, 2020
@averikitsch averikitsch added priority: p2 Moderately-important priority. Fix may not be included in next release. and removed priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels Dec 7, 2020
@yoshi-automation yoshi-automation removed the 🚨 This issue needs some love. label Dec 7, 2020
@averikitsch averikitsch mentioned this issue Dec 8, 2020
Merged
@averikitsch
Copy link
Contributor

Fixed by #2097

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@averikitsch averikitsch

Labels
api: run Issues related to the Cloud Run API. priority: p2 Moderately-important priority. Fix may not be included in next release. samples Issues that are directly related to samples. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@grayside @averikitsch @yoshi-automation