Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[App Engine] TS : Adding the missing node type definition #2068

Merged
merged 4 commits into from
Nov 16, 2020

Conversation

Alutun
Copy link
Contributor

@Alutun Alutun commented Nov 11, 2020

The Typescript example is actually not working.
When App Engine is running the npm run gcp-build

It will throw erros like this one :

Step #6 - "builder": index.ts(17,21): error TS2580: Cannot find name 'process'.

The package.json is missing the node Types definitions module.

My pull request is fixing that.

Best

@google-cla
Copy link

google-cla bot commented Nov 11, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no This human has *not* signed the Contributor License Agreement. label Nov 11, 2020
@Alutun Alutun changed the title Adding the missing node type definition [App Engine] TS : Adding the missing node type definition Nov 11, 2020
@Alutun
Copy link
Contributor Author

Alutun commented Nov 11, 2020

@googlebot I signed it!

@google-cla google-cla bot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Nov 11, 2020
@fhinkel fhinkel added automerge Merge the pull request once unit tests and other checks pass. kokoro:run Add this label to force Kokoro to re-run the tests. labels Nov 11, 2020
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Nov 11, 2020
@gcf-merge-on-green
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, or one of your required reviews was not approved. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

1 similar comment
@gcf-merge-on-green
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, or one of your required reviews was not approved. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Nov 11, 2020
@fhinkel fhinkel added the kokoro:run Add this label to force Kokoro to re-run the tests. label Nov 16, 2020
@kokoro-team kokoro-team removed kokoro:run Add this label to force Kokoro to re-run the tests. labels Nov 16, 2020
@fhinkel fhinkel added the kokoro:run Add this label to force Kokoro to re-run the tests. label Nov 16, 2020
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Nov 16, 2020
@fhinkel fhinkel added the automerge Merge the pull request once unit tests and other checks pass. label Nov 16, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit ad9fb39 into GoogleCloudPlatform:master Nov 16, 2020
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants