Skip to content

Commit

Permalink
[App Engine] TS : Adding the missing node type definition (#2068)
Browse files Browse the repository at this point in the history
The Typescript example is actually not working.
When App Engine is running the `npm run gcp-build`

It will throw erros like this one : 

`Step` #6 - "builder": index.ts(17,21): error TS2580: Cannot find name 'process'. 

The package.json is missing the node Types definitions module. 

My pull request is fixing that. 

Best
  • Loading branch information
Alutun authored Nov 16, 2020
1 parent f7968e9 commit ad9fb39
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions appengine/typescript/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
"typescript": "^4.0.0"
},
"devDependencies": {
"@types/node": "^14.14.7",
"mocha": "^8.0.0",
"wait-port": "^0.2.7",
"@types/express": "^4.16.0",
Expand Down

0 comments on commit ad9fb39

Please sign in to comment.