Fix provider configuration code to handle Unknown values correctly #8943

SarahFrench · 2023-09-13T19:02:51Z

Fixes hashicorp/terraform-provider-google#14444

Related to #8798

Release Note Template for Downstream PRs (will be copied)

provider: addressed a bug where configuring the provider with unknown values did not behave as expected

modular-magician · 2023-09-13T20:31:19Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 230 insertions(+), 183 deletions(-))
Terraform Beta: Diff ( 3 files changed, 230 insertions(+), 183 deletions(-))

modular-magician · 2023-09-13T21:44:30Z

Tests analytics

Total tests: 3037
Passed tests 2736
Skipped tests: 297
Affected tests: 4

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccMonitoringMonitoredProject_monitoringMonitoredProjectLongFormExample|TestAccMonitoringMonitoredProject_projectNumShortForm|TestAccMonitoringMonitoredProject_projectNumLongForm|TestAccMonitoringMonitoredProject_monitoringMonitoredProjectBasicExample

Get to know how VCR tests work

modular-magician · 2023-09-13T21:53:14Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccMonitoringMonitoredProject_monitoringMonitoredProjectLongFormExample[Debug log]
TestAccMonitoringMonitoredProject_projectNumShortForm[Debug log]
TestAccMonitoringMonitoredProject_projectNumLongForm[Debug log]
TestAccMonitoringMonitoredProject_monitoringMonitoredProjectBasicExample[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

… `credentials` tests pass

…pass

…t pass

…t test pass

…, make those tests pass

…be set to same defaults as if they were null, update test

…etBatchingConfig` is used by the code

…ntDelegates values

SarahFrench · 2023-09-14T19:24:54Z

I've yet to manually test this change to see if this use case from the original issue works as expected again:

provider "google-beta" {
  project     = "foo"
  credentials = base64decode(google_service_account_key.terraform_service_account.private_key)
}

modular-magician · 2023-09-14T19:26:14Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 227 insertions(+), 175 deletions(-))
Terraform Beta: Diff ( 2 files changed, 227 insertions(+), 175 deletions(-))

mmv1/third_party/terraform/fwtransport/framework_config_test.go.erb

modular-magician · 2023-09-14T20:44:13Z

Tests analytics

Total tests: 3044
Passed tests 2745
Skipped tests: 298
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDataSourceGoogleServiceAccountIdToken_impersonation

Get to know how VCR tests work

modular-magician · 2023-09-14T20:47:04Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDataSourceGoogleServiceAccountIdToken_impersonation[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

…rovider config Only testing `credentials` currently.

SarahFrench · 2023-09-19T16:16:54Z

I manually tested the use case from the original issue (see comment) and I've added a non-VCR acceptance test that asserts the provider's behaviour.

I've tried to implement that test in a way so it uses the code in the repo (instead of downloading from the Terraform Registry) but kept hitting issues. The above is good enough for now I think.

modular-magician · 2023-09-19T16:24:57Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 378 insertions(+), 175 deletions(-))
Terraform Beta: Diff ( 3 files changed, 378 insertions(+), 175 deletions(-))

modular-magician · 2023-09-19T17:37:38Z

Tests analytics

Total tests: 3070
Passed tests 2770
Skipped tests: 300
Affected tests: 0

$\textcolor{green}{\textsf{All tests passed in REPLAYING mode.}}$
View the build log

…oogleCloudPlatform#8943) * Uncomment test cases for unknown values * Update test case names * Update unknown value test for `project`, make it pass * Update unknown value test for `access_token`, make `access_token` and `credentials` tests pass * Update unknown value tests for `region` and `zone`, make those tests pass * Update unknown value tests for `user_project_override`, make that test pass * Update unknown value test for `impersonate_service_account`, make that test pass * Update unknown value tests for `request_reason` and `request_timeout`, make those tests pass * Make unknown batching.send_after and batching.enable_batching values be set to same defaults as if they were null, update test * Update code to handle when the whole batching block is Unknown * Update the test function for `batching` unit tests to navigate how `GetBatchingConfig` is used by the code * Update code to handle null/unknown Scopes and ImpersonateServiceAccountDelegates values * Improve `impersonate_service_account_delegates` tests for unknown values * Add missing null test case for `batching` field * Add non-VCR acceptance test to assert handling of unknown values in provider config Only testing `credentials` currently.

This comment was marked as outdated.

Sign in to view

SarahFrench force-pushed the make-pf-handle-unknown-values-like-nulls branch from 70f072d to 0c5b503 Compare September 13, 2023 20:21

SarahFrench added 13 commits September 14, 2023 19:04

Uncomment test cases for unknown values

c5bb798

Update test case names

e2801cd

Update unknown value test for project, make it pass

2b25ad0

Update unknown value test for access_token, make access_token and…

47c06cf

… `credentials` tests pass

Update unknown value tests for region and zone, make those tests …

4f56cf5

…pass

Update unknown value tests for user_project_override, make that tes…

8609564

…t pass

Update unknown value test for impersonate_service_account, make tha…

a5401b1

…t test pass

Update unknown value tests for request_reason and request_timeout…

2fe75ac

…, make those tests pass

Make unknown batching.send_after and batching.enable_batching values …

f4536d3

…be set to same defaults as if they were null, update test

Update code to handle when the whole batching block is Unknown

6f4af5a

Update the test function for batching unit tests to navigate how `G…

43ef3c5

…etBatchingConfig` is used by the code

Update code to handle null/unknown Scopes and ImpersonateServiceAccou…

338961d

…ntDelegates values

Improve impersonate_service_account_delegates tests for unknown values

cd9fde2

SarahFrench force-pushed the make-pf-handle-unknown-values-like-nulls branch from 0c5b503 to cd9fde2 Compare September 14, 2023 18:07

This comment was marked as outdated.

Sign in to view

Add missing null test case for batching field

54564b9

SarahFrench marked this pull request as ready for review September 14, 2023 19:23

SarahFrench requested a review from rileykarson September 14, 2023 19:25

rileykarson approved these changes Sep 14, 2023

View reviewed changes

mmv1/third_party/terraform/fwtransport/framework_config_test.go.erb Show resolved Hide resolved

Add non-VCR acceptance test to assert handling of unknown values in p…

15761f7

…rovider config Only testing `credentials` currently.

SarahFrench merged commit b162a69 into main Sep 19, 2023

This was referenced Sep 19, 2023

Fix provider configuration code to handle Unknown values correctly hashicorp/terraform-provider-google-beta#6312

Merged

Fix provider configuration code to handle Unknown values correctly hashicorp/terraform-provider-google#15898

Merged

SarahFrench mentioned this pull request Sep 20, 2023

Comment out PF provider config test that's affected by ADCs in our CI #9034

Merged

This was referenced Sep 20, 2023

Comment out PF provider config test that's affected by ADCs in our CI hashicorp/terraform-provider-google-beta#6326

Merged

Comment out PF provider config test that's affected by ADCs in our CI hashicorp/terraform-provider-google#15924

Merged

SarahFrench deleted the make-pf-handle-unknown-values-like-nulls branch September 26, 2023 13:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix provider configuration code to handle Unknown values correctly #8943

Fix provider configuration code to handle Unknown values correctly #8943

SarahFrench commented Sep 13, 2023 •

edited

Loading

This comment was marked as outdated.

modular-magician commented Sep 13, 2023

modular-magician commented Sep 13, 2023

modular-magician commented Sep 13, 2023

This comment was marked as outdated.

SarahFrench commented Sep 14, 2023

modular-magician commented Sep 14, 2023

modular-magician commented Sep 14, 2023

modular-magician commented Sep 14, 2023

SarahFrench commented Sep 19, 2023 •

edited

Loading

modular-magician commented Sep 19, 2023

modular-magician commented Sep 19, 2023

Fix provider configuration code to handle Unknown values correctly #8943

Fix provider configuration code to handle Unknown values correctly #8943

Conversation

SarahFrench commented Sep 13, 2023 • edited Loading

This comment was marked as outdated.

modular-magician commented Sep 13, 2023

Diff report

modular-magician commented Sep 13, 2023

Tests analytics

Action taken

modular-magician commented Sep 13, 2023

Rerun these tests in REPLAYING mode to catch issues

This comment was marked as outdated.

SarahFrench commented Sep 14, 2023

modular-magician commented Sep 14, 2023

Diff report

modular-magician commented Sep 14, 2023

Tests analytics

Action taken

modular-magician commented Sep 14, 2023

Rerun these tests in REPLAYING mode to catch issues

SarahFrench commented Sep 19, 2023 • edited Loading

modular-magician commented Sep 19, 2023

Diff report

modular-magician commented Sep 19, 2023

Tests analytics

SarahFrench commented Sep 13, 2023 •

edited

Loading

SarahFrench commented Sep 19, 2023 •

edited

Loading