Skip to content

Commit

Permalink
Update duration values to value under 1 minute
Browse files Browse the repository at this point in the history
  • Loading branch information
SarahFrench committed Sep 13, 2023
1 parent 82ba091 commit 0c5b503
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -1556,9 +1556,9 @@ func TestFrameworkProvider_LoadAndValidateFramework_batching(t *testing.T) {
}{
"batching can be configured with values for enable_batching and send_after": {
EnableBatchingValue: types.BoolValue(true),
SendAfterValue: types.StringValue("123s"),
SendAfterValue: types.StringValue("45s"),
ExpectEnableBatchingValue: types.BoolValue(true),
ExpectSendAfterValue: types.StringValue("123s"),
ExpectSendAfterValue: types.StringValue("45s"),
},
"if batching is an empty block, it will set the default values for enable_batching and send_after": {
// In this test, we try to create a list containing only null values
Expand All @@ -1575,9 +1575,9 @@ func TestFrameworkProvider_LoadAndValidateFramework_batching(t *testing.T) {
},
"when batching is configured with only send_after, enable_batching will be set to a default value": {
EnableBatchingValue: types.BoolNull(),
SendAfterValue: types.StringValue("123s"),
SendAfterValue: types.StringValue("45s"),
ExpectEnableBatchingValue: types.BoolValue(true),
ExpectSendAfterValue: types.StringValue("123s"),
ExpectSendAfterValue: types.StringValue("45s"),
},
// Handling empty strings in config
// TODO(SarahFrench) make these tests pass to address: https://github.com/hashicorp/terraform-provider-google/issues/14255
Expand Down
8 changes: 4 additions & 4 deletions mmv1/third_party/terraform/provider/provider_internal_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -1571,12 +1571,12 @@ func TestProvider_ProviderConfigure_batching(t *testing.T) {
"batching": []interface{}{
map[string]interface{}{
"enable_batching": true,
"send_after": "123s",
"send_after": "45s",
},
},
},
ExpectedEnableBatchingValue: true,
ExpectedSendAfterValue: "123s",
ExpectedSendAfterValue: "45s",
},
"if batching is an empty block, it will set the default values for enable_batching and send_after": {
ConfigValues: map[string]interface{}{
Expand Down Expand Up @@ -1607,12 +1607,12 @@ func TestProvider_ProviderConfigure_batching(t *testing.T) {
"credentials": transport_tpg.TestFakeCredentialsPath,
"batching": []interface{}{
map[string]interface{}{
"send_after": "123s",
"send_after": "45s",
},
},
},
ExpectedEnableBatchingValue: false,
ExpectedSendAfterValue: "123s",
ExpectedSendAfterValue: "45s",
},
// Error states
"if batching is configured with send_after as an invalid value, there's an error": {
Expand Down

0 comments on commit 0c5b503

Please sign in to comment.