Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable CloudIdsEndpoint sweeper #7071

Merged
merged 1 commit into from
Jan 5, 2023
Merged

Conversation

roaks3
Copy link
Contributor

@roaks3 roaks3 commented Jan 3, 2023

This sweeper is failing consistently with a 502, and because of how the retry logic works with a 502, it ends up trying for 5+ minutes and prevents our nightly sweeper task from finishing (11 minute timeout).

This is a very similar pattern and solution as #7034

For more detail, issue captured here for re-enabling the sweeper: hashicorp/terraform-provider-google#13375

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)


@roaks3 roaks3 requested review from a team and ScottSuarez and removed request for a team January 3, 2023 22:20
@roaks3
Copy link
Contributor Author

roaks3 commented Jan 3, 2023

cc @hao-nan-li for awareness, there seems to be a bit of a pattern where sweepers assume region, but sometimes need to use zone

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 124 deletions(-))
Terraform Beta: Diff ( 1 file changed, 124 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

The provider crashed while running the VCR tests in REPLAYING mode
Please fix it to complete your PR
View the build log

@melinath
Copy link
Member

melinath commented Jan 4, 2023

/gcbrun

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 124 deletions(-))
Terraform Beta: Diff ( 1 file changed, 124 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2386
Passed tests 2136
Skipped tests: 248
Failed tests: 2

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccContainerCluster_withInvalidGatewayApiConfigChannel|TestAccFirebaserulesRelease_BasicRelease

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccContainerCluster_withInvalidGatewayApiConfigChannel[Debug log]
TestAccFirebaserulesRelease_BasicRelease[Debug log]

All tests passed
View the build log or the debug log for each test

@roaks3
Copy link
Contributor Author

roaks3 commented Jan 4, 2023

Re-rolling because Scott is out today

@roaks3 roaks3 requested review from a team and zli82016 and removed request for ScottSuarez and a team January 4, 2023 19:12
@zli82016 zli82016 requested review from a team, ScottSuarez, zli82016 and slevenick and removed request for zli82016, a team and ScottSuarez January 5, 2023 18:45
Copy link
Member

@zli82016 zli82016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@zli82016
Copy link
Member

zli82016 commented Jan 5, 2023

Added @slevenick as the secondary reviewer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants