-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable CloudIdsEndpoint sweeper #7071
Conversation
cc @hao-nan-li for awareness, there seems to be a bit of a pattern where sweepers assume region, but sometimes need to use zone |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 1 file changed, 124 deletions(-)) |
The provider crashed while running the VCR tests in REPLAYING mode |
/gcbrun |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 1 file changed, 124 deletions(-)) |
Tests analyticsTotal tests: Action takenTriggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed testsTestAccContainerCluster_withInvalidGatewayApiConfigChannel|TestAccFirebaserulesRelease_BasicRelease |
Re-rolling because Scott is out today |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Added @slevenick as the secondary reviewer. |
This sweeper is failing consistently with a 502, and because of how the retry logic works with a 502, it ends up trying for 5+ minutes and prevents our nightly sweeper task from finishing (11 minute timeout).
This is a very similar pattern and solution as #7034
For more detail, issue captured here for re-enabling the sweeper: hashicorp/terraform-provider-google#13375
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)