-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable OSPolicyAssisgnment sweeper #7034
Conversation
Oops! It looks like you're using an unknown release-note type in your changelog entries:
Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md. |
fyi @hao-nan-li: no action yet, but this is one of the types of error the sweepers can have for later in the quarter! |
Tests analyticsTotal tests: Action takenTriggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed testsTestAccContainerCluster_withInvalidGatewayApiConfigChannel|TestAccBigtableAppProfile_bigtableAppProfileMulticlusterExample |
I created this issue for tracking a fix hashicorp/terraform-provider-google#13338 |
Noted, thanks! |
This sweeper is failing consistently with a 501, and because of how the retry logic works with a 501, it ends up trying for 6+ minutes and causes our whole sweeper task to timeout.
The 501 appears to come from the
location
parameter, which is assumed by the DCL to take a region, but it actually only accepts a zone. Passing in a region causes a 501, while passing in a zone succeeds. However, since this fix looks like it could be more involved and require tinkering with the DCL generator, it seems fair to disable the sweeper for now because it doesn't work.If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)