Fix inconsistent locations in some resources - Part II

[upodroid]

@melinath

Part of #4377

If this PR is for Terraform, I acknowledge that I have:

• Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
• Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
• Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
• Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
• Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

memcache: fixed an issue where `google_memcached_instance` resource was not inferring the region from the provider.

vpcaccess: fixed an issue where `google_vpc_access_connector` resource was not inferring the region from the provider.

tpu: fixed an issue where `google_tpu_node` resource was not inferring the zone from the provider.

[modular-magician]

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@ScottSuarez, please review this PR or find an appropriate assignee.

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 6 files changed, 26 insertions(+), 27 deletions(-))
Terraform Beta: Diff ( 8 files changed, 33 insertions(+), 42 deletions(-))
Ansible: Diff ( 2 files changed, 9 insertions(+), 8 deletions(-))
TF OiCS: Diff ( 2 files changed, 2 deletions(-))
Inspec: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

[melinath]

/gcbrun

[modular-magician]

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=166694"

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 6 files changed, 26 insertions(+), 27 deletions(-))
Terraform Beta: Diff ( 9 files changed, 34 insertions(+), 43 deletions(-))
Ansible: Diff ( 2 files changed, 9 insertions(+), 8 deletions(-))
TF OiCS: Diff ( 2 files changed, 2 deletions(-))
Inspec: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

[melinath]

These changes seem reasonable to me. Just have one question about the test examples.

[melinath]

Also, could the release note be updated to be per-product? Specifically, three separate code blocks, one for each product being altered. That'll make it be displayed correctly in the downstream changelog. Thanks!

[upodroid]

fixed the release notes

[modular-magician]

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccInstanceTemplateDatasource_filter|TestAccInstanceTemplateDatasource_filter_mostRecent|TestAccDataSourceGoogleSubnetwork|TestAccDataSourceStorageBucketObjectContent_Basic|TestAccActiveDirectoryDomainTrust_activeDirectoryDomainTrustBasicExample|TestAccApigeeOrganization_apigeeOrganizationCloudFullTestExample|TestAccCloudRunService_cloudRunServiceSqlExample|TestAccContainerCluster_withPrivateClusterConfigMissingCidrBlock You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=166697"

[melinath]

LGTM - thanks!