Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cloud Run Locations datasource #4360

Merged
merged 12 commits into from
Jan 13, 2021

Conversation

upodroid
Copy link
Contributor

@upodroid upodroid commented Jan 4, 2021

Fixes: hashicorp/terraform-provider-google#7850

@ahmetb

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

`google_cloud_run_locations`

@google-cla google-cla bot added the cla: yes label Jan 4, 2021
@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@rileykarson, please review this PR or find an appropriate assignee.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 13 files changed, 252 insertions(+), 20 deletions(-))
Terraform Beta: Diff ( 13 files changed, 252 insertions(+), 20 deletions(-))
TF OiCS: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

Copy link

@ahmetb ahmetb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this.


func flattenCloudRunLocations(resp map[string]interface{}) []interface{} {
regionList := resp["locations"].([]interface{})
regions := make([]interface{}, len(regionList))
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason why we don't use strong types here? Locations response struct exists in run/v1 package.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general it's fine either way- for example I want to say the TPU service library didn't exist yet, or we hadn't imported the service library and preferred not to.


func flattenCloudRunLocations(resp map[string]interface{}) []interface{} {
regionList := resp["locations"].([]interface{})
regions := make([]interface{}, len(regionList))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general it's fine either way- for example I want to say the TPU service library didn't exist yet, or we hadn't imported the service library and preferred not to.

third_party/terraform/utils/provider.go.erb Outdated Show resolved Hide resolved
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 13 files changed, 252 insertions(+), 20 deletions(-))
Terraform Beta: Diff ( 13 files changed, 252 insertions(+), 20 deletions(-))
TF OiCS: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

1 similar comment
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 13 files changed, 252 insertions(+), 20 deletions(-))
Terraform Beta: Diff ( 13 files changed, 252 insertions(+), 20 deletions(-))
TF OiCS: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

@rileykarson
Copy link
Member

/gcbrun

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=165642"

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 13 files changed, 252 insertions(+), 20 deletions(-))
Terraform Beta: Diff ( 13 files changed, 252 insertions(+), 20 deletions(-))
TF OiCS: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDataSourceGoogleSubnetwork|TestAccDataSourceStorageBucketObjectContent_Basic|TestAccCloudRunServiceIamBindingGenerated|TestAccCloudRunServiceIamMemberGenerated|TestAccCloudRunServiceIamPolicyGenerated|TestAccActiveDirectoryDomainTrust_activeDirectoryDomainTrustBasicExample|TestAccCloudRunDomainMapping_cloudRunDomainMappingBasicExample|TestAccCloudRunService_cloudRunServiceMultipleEnvironmentVariablesExample|TestAccCloudRunService_cloudRunServiceBasicExample|TestAccCloudRunService_cloudRunServiceSqlExample|TestAccCloudRunService_cloudRunServiceNoauthExample|TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupCloudrunExample|TestAccContainerCluster_withConfidentialNodes|TestAccContainerCluster_withPrivateClusterConfigMissingCidrBlock|TestAccDataprocJob_Spark You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=165649"

@ahmetb
Copy link

ahmetb commented Jan 13, 2021

Thanks for contributing this. I personally really appreciate.
CC @imjasonh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add google_cloud_run_locations data source
4 participants