-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Private Service Connect to Looker #11487
Merged
Merged
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
790bb90
Update Instance.yaml for Looker to support PSC
efeelaiho c623b0b
Create looker_instance_psc.tf.erb
efeelaiho 11e4b82
Merge branch 'GoogleCloudPlatform:main' into add-psc
efeelaiho ee093ce
Merge branch 'GoogleCloudPlatform:main' into add-psc
efeelaiho fb3d96d
Update Instance.yaml - remove trailing spaces
efeelaiho 24f800d
Update looker_instance_psc.tf.erb
efeelaiho e366362
Update Instance.yaml
efeelaiho 17d15da
Update looker_instance_psc.tf.erb
efeelaiho File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 changes: 17 additions & 0 deletions
17
mmv1/templates/terraform/examples/looker_instance_psc.tf.erb
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
resource "google_looker_instance" "<%= ctx[:primary_resource_id] %>" { | ||
efeelaiho marked this conversation as resolved.
Show resolved
Hide resolved
|
||
name = "<%= ctx[:vars]["instance_name"] %>" | ||
platform_edition = "LOOKER_CORE_ENTERPRISE_ANNUAL" | ||
region = "us-central1" | ||
private_ip_enabled = false | ||
public_ip_enabled = false | ||
psc_enabled = true | ||
oauth_config { | ||
client_id = "<%= ctx[:vars]["client_id"] %>" | ||
client_secret = "<%= ctx[:vars]["client_secret"] %>" | ||
} | ||
psc_config { | ||
allowed_vpcs: ["projects/test-project/global/networks/test"] | ||
# update only | ||
# service_attachments: [{local_fqdn: "www.local-fqdn.com" target_service_attachment_uri: "projects/my-project/regions/us-east1/serviceAttachments/sa"}] | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
interesting... this is usually in the config field itself.