Add Private Service Connect to Looker

[efeelaiho]

Adding Add Private Service Connect (PSC) connection to Looker instances

Release Note Template for Downstream PRs (will be copied)

looker:  added `psc_enabled` and `psc_config` to `google_looker_instance` resource

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 284 insertions(+))
google-beta provider: Diff ( 2 files changed, 284 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 105 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_looker_instance (6 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_looker_instance" "primary" {
  psc_config {
    allowed_vpcs = # value needed
    service_attachments {
      local_fqdn                    = # value needed
      target_service_attachment_uri = # value needed
    }
  }
  psc_enabled = # value needed
}

[modular-magician]

Tests analytics

Total tests: 5
Passed tests: 5
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• looker

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

[efeelaiho]

@c2thorn any thing I should do here to get this merged?

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 284 insertions(+))
google-beta provider: Diff ( 2 files changed, 284 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 105 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_looker_instance (6 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_looker_instance" "primary" {
  psc_config {
    allowed_vpcs = # value needed
    service_attachments {
      local_fqdn                    = # value needed
      target_service_attachment_uri = # value needed
    }
  }
  psc_enabled = # value needed
}

[modular-magician]

Tests analytics

Total tests: 5
Passed tests: 5
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• looker

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

[github-actions]

@c2thorn This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[github-actions]

@GoogleCloudPlatform/terraform-team @c2thorn This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

[c2thorn]

are these meant to be commented out? Terraform comments use "#"

But if you are trying to make an update test, that should be done in a handwritten file. I'm not sure if one already exists for looker, but you can see our documentation here: https://googlecloudplatform.github.io/magic-modules/develop/test/test/#add-an-update-test

[c2thorn]

can you also update the release note to be in this specific style: https://googlecloudplatform.github.io/magic-modules/contribute/release-notes/

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 284 insertions(+))
google-beta provider: Diff ( 2 files changed, 284 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 105 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 118 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_looker_instance (6 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_looker_instance" "primary" {
  psc_config {
    allowed_vpcs = # value needed
    service_attachments {
      local_fqdn                    = # value needed
      target_service_attachment_uri = # value needed
    }
  }
  psc_enabled = # value needed
}

[modular-magician]

Tests analytics

Total tests: 6
Passed tests: 5
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• looker

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccLookerInstance_lookerInstancePscExample

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccLookerInstance_lookerInstancePscExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 358 insertions(+))
google-beta provider: Diff ( 3 files changed, 358 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 105 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 118 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_looker_instance (6 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_looker_instance" "primary" {
  psc_config {
    allowed_vpcs = # value needed
    service_attachments {
      local_fqdn                    = # value needed
      target_service_attachment_uri = # value needed
    }
  }
  psc_enabled = # value needed
}

[modular-magician]

Tests analytics

Total tests: 6
Passed tests: 5
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• looker

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccLookerInstance_lookerInstancePscExample

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccLookerInstance_lookerInstancePscExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

[github-actions]

@c2thorn This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[github-actions]

@GoogleCloudPlatform/terraform-team @c2thorn This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

[github-actions]

@GoogleCloudPlatform/terraform-team @c2thorn This PR has been waiting for review for 2 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

[c2thorn]

test is still failing with

        Error: Argument or block definition required
        
          on terraform_plugin_test.tf line 14, in resource "google_looker_instance" "looker-instance":
          14:     allowed_vpcs: ["projects/test-project/global/networks/test"]
        
        An argument or block definition is required here. To set an argument, use the
        equals sign "=" to introduce the argument value.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 358 insertions(+))
google-beta provider: Diff ( 3 files changed, 358 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 105 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 118 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_looker_instance (8 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_looker_instance" "primary" {
  psc_config {
    service_attachments {
      local_fqdn                    = # value needed
      target_service_attachment_uri = # value needed
    }
  }
}

[modular-magician]

Tests analytics

Total tests: 7
Passed tests: 6
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• looker

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccLookerInstance_lookerInstancePscExample

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccLookerInstance_lookerInstancePscExample[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log or the debug log for each test

[c2thorn]

interesting... this is usually in the config field itself.