-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change IAM binding to be authoritative #1116
Change IAM binding to be authoritative #1116
Conversation
I am a robot that works on MagicModules PRs! I built this PR into one or more PRs on other repositories, and when those are closed, this PR will also be merged and closed. |
third_party/terraform/website/docs/r/google_billing_account_iam_binding.md
Outdated
Show resolved
Hide resolved
third_party/terraform/website/docs/r/google_billing_account_iam_binding.md
Show resolved
Hide resolved
I am (still) a robot that works on MagicModules PRs! I just wanted to let you know that your changes (as of commit 71b2de0) have been included in your existing downstream PRs. |
I am (still) a robot that works on MagicModules PRs! I just wanted to let you know that your changes (as of commit ae345cb) have been included in your existing downstream PRs. |
I am (still) a robot that works on MagicModules PRs! I just wanted to let you know that your changes (as of commit bdea511) have been included in your existing downstream PRs. |
third_party/terraform/website/docs/version_2_upgrade.html.markdown
Outdated
Show resolved
Hide resolved
third_party/terraform/website/docs/version_2_upgrade.html.markdown
Outdated
Show resolved
Hide resolved
third_party/terraform/website/docs/r/google_billing_account_iam_binding.md
Show resolved
Hide resolved
Sorry for the delay! I didn't notice the code pushes (I get emailed for comments but only a blue dot in GitHub for push) |
I am (still) a robot that works on MagicModules PRs! I just wanted to let you know that your changes (as of commit fc8cc6a) have been included in your existing downstream PRs. |
third_party/terraform/website/docs/version_2_upgrade.html.markdown
Outdated
Show resolved
Hide resolved
I am (still) a robot that works on MagicModules PRs! I just wanted to let you know that your changes (as of commit d401d00) have been included in your existing downstream PRs. |
e52ba51
to
4ac3327
Compare
I am (still) a robot that works on MagicModules PRs! I just wanted to let you know that your changes (as of commit 8fa710a) have been included in your existing downstream PRs. |
Change the wording to be more explicit that the email/users created must be associated with a valid google account. This is partially because the error that is returned from the api when you use a non google account is very generic and isn't clear why it's failing.
Create and Update are identical in functionality so this will use the same method for both of them rather then duplicated code.
…m_binding.md Co-Authored-By: chrisst <chrisst@google.com>
…down Co-Authored-By: chrisst <chrisst@google.com>
Tracked submodules are build/terraform-beta build/terraform build/ansible build/inspec.
4ac3327
to
872633c
Compare
fixes hashicorp/terraform-provider-google#2449
[all]
Change IAM binding to be authoritative
[terraform]
[terraform-beta]
[ansible]
[inspec]