Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change IAM binding to be authoritative #1116

Merged

Conversation

chrisst
Copy link
Contributor

@chrisst chrisst commented Dec 28, 2018

fixes hashicorp/terraform-provider-google#2449


[all]

Change IAM binding to be authoritative

[terraform]

[terraform-beta]

[ansible]

[inspec]

@modular-magician
Copy link
Collaborator

I am a robot that works on MagicModules PRs!

I built this PR into one or more PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#291
depends: hashicorp/terraform-provider-google#2764

@modular-magician
Copy link
Collaborator

I am (still) a robot that works on MagicModules PRs!

I just wanted to let you know that your changes (as of commit 71b2de0) have been included in your existing downstream PRs.

@modular-magician
Copy link
Collaborator

I am (still) a robot that works on MagicModules PRs!

I just wanted to let you know that your changes (as of commit ae345cb) have been included in your existing downstream PRs.

@modular-magician
Copy link
Collaborator

I am (still) a robot that works on MagicModules PRs!

I just wanted to let you know that your changes (as of commit bdea511) have been included in your existing downstream PRs.

@rileykarson
Copy link
Member

Sorry for the delay! I didn't notice the code pushes (I get emailed for comments but only a blue dot in GitHub for push)

@modular-magician
Copy link
Collaborator

I am (still) a robot that works on MagicModules PRs!

I just wanted to let you know that your changes (as of commit fc8cc6a) have been included in your existing downstream PRs.

@modular-magician
Copy link
Collaborator

I am (still) a robot that works on MagicModules PRs!

I just wanted to let you know that your changes (as of commit d401d00) have been included in your existing downstream PRs.

@modular-magician
Copy link
Collaborator

I am (still) a robot that works on MagicModules PRs!

I just wanted to let you know that your changes (as of commit 8fa710a) have been included in your existing downstream PRs.

chrisst and others added 9 commits January 4, 2019 23:36
Change the wording to be more explicit that the email/users created must be
associated with a valid google account. This is partially because the error that
is returned from the api when you use a non google account is very generic and
isn't clear why it's failing.
Create and Update are identical in functionality so this will use the same
method for both of them rather then duplicated code.
…m_binding.md

Co-Authored-By: chrisst <chrisst@google.com>
…down

Co-Authored-By: chrisst <chrisst@google.com>
Tracked submodules are build/terraform-beta build/terraform build/ansible build/inspec.
@modular-magician modular-magician merged commit e339329 into GoogleCloudPlatform:master Jan 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

google_*_iam_binding should be authoritative
4 participants