Television device and features #1139
Conversation
atrovato
force-pushed
the
television-device
branch
2 times, most recently
from
906f3de to
7807a98
Compare
Codecov Report
@@ Coverage Diff @@
## master #1139 +/- ##
=======================================
Coverage 96.27% 96.27%
=======================================
Files 639 639
Lines 8110 8110
=======================================
Hits 7808 7808
Misses 302 302
Continue to review full report at Codecov.
|
|
I was just working on something similar. I wonder if creating a generic "media player" device might allow us to consolidate audio players too? Here's my work in progress for reference master...rob-mccann:media-device |
| @@ -13,7 +13,8 @@ import actions from '../../../actions/dashboard/edit-boxes/editDevicesInRoom'; | |||
| const SUPPORTED_FEATURE_TYPES = [ | |||
| DEVICE_FEATURE_TYPES.LIGHT.BINARY, | |||
| DEVICE_FEATURE_TYPES.LIGHT.COLOR, | |||
| DEVICE_FEATURE_TYPES.LIGHT.BRIGHTNESS | |||
| DEVICE_FEATURE_TYPES.TELEVISION.CHANNEL, | |||
There was a problem hiding this comment.
Not sure if you want to include it but televisions also have a source (HDMI1, HDMI2, TV etc) in addition to a channel
| "channel-up": "Channel up", | ||
| "channel-previous": "Previous channel", | ||
| "channel-down": "Channel down", | ||
| "tools": "Tools", |
There was a problem hiding this comment.
is this common to all TVs?
There was a problem hiding this comment.
ah I see below - perhaps this should be Settings?
There was a problem hiding this comment.
On my Samsung remote, I see "TOOLS", but settings is acceptable.
I'll wait when this is ready for review.
|
I think we have to keep them separated, as tv, audio, or dvd player might not do the same... but they share 80% of their features... |
|
Is that something we could cover off by having a device that is tagged with specific "features"? Just to add a third type in there is a games console where the media might be a video game :) |
|
Ok, you're work looks really good, so I only need more features related to TV device. (this is PR is a split of a bigger one, to manage IR remote with broadlink, I can continue broadlink service without it for now) |
|
After more reflexion, I think we need to have 'tv', 'game', 'music' categories to easily and clearly distinguish it. |
|
I'm still feeling my way through the codebase so definitely appreciate ideas and support! |
atrovato
force-pushed
the
television-device
branch
from
7807a98 to
41666af
Compare
atrovato
force-pushed
the
television-device
branch
from
41666af to
4973cba
Compare
|
Hello! Just wanted to know the status of this PR ? :) |
|
I close it for now. |
Based on #1138
Add television category, features, icons, and some dashboard actions.