-
-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Single range box #1138
Single range box #1138
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1138 +/- ##
==========================================
- Coverage 96.30% 96.27% -0.03%
==========================================
Files 639 639
Lines 8141 8110 -31
==========================================
- Hits 7840 7808 -32
- Misses 301 302 +1
Continue to review full report at Codecov.
|
0e3b44a
to
f9fc726
Compare
f9fc726
to
aaf6436
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally, looks good to me
// if not, we return nothing | ||
return null; | ||
|
||
return createElement(elementType, props); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very nice, didn't know about createElement :) I learnt something today!
Use single Range feature dashbox feature row.
Based on #1137