Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single range box #1138

Merged
merged 1 commit into from
Apr 23, 2021
Merged

Conversation

atrovato
Copy link
Contributor

@atrovato atrovato commented Apr 9, 2021

Use single Range feature dashbox feature row.

Based on #1137

@codecov
Copy link

codecov bot commented Apr 9, 2021

Codecov Report

Merging #1138 (f9fc726) into master (4cf4752) will decrease coverage by 0.02%.
The diff coverage is n/a.

❗ Current head f9fc726 differs from pull request most recent head aaf6436. Consider uploading reports for the commit aaf6436 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1138      +/-   ##
==========================================
- Coverage   96.30%   96.27%   -0.03%     
==========================================
  Files         639      639              
  Lines        8141     8110      -31     
==========================================
- Hits         7840     7808      -32     
- Misses        301      302       +1     
Impacted Files Coverage Δ
server/utils/constants.js 100.00% <ø> (ø)
server/lib/scene/scene.execute.js 91.66% <0.00%> (-8.34%) ⬇️
server/lib/scene/scene.actions.js 96.55% <0.00%> (-0.80%) ⬇️
server/lib/scene/scene.triggers.js 93.75% <0.00%> (-0.70%) ⬇️
server/models/scene.js 93.75% <0.00%> (ø)
server/lib/house/house.userLeft.js 100.00% <0.00%> (ø)
server/lib/house/house.userSeen.js 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cf4752...aaf6436. Read the comment docs.

@atrovato atrovato marked this pull request as ready for review April 22, 2021 16:37
@atrovato atrovato requested review from VonOx and Pierre-Gilles April 22, 2021 17:14
Copy link
Contributor

@Pierre-Gilles Pierre-Gilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, looks good to me

// if not, we return nothing
return null;

return createElement(elementType, props);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice, didn't know about createElement :) I learnt something today!

@Pierre-Gilles Pierre-Gilles merged commit 22dc3e9 into GladysAssistant:master Apr 23, 2021
Jean-PhilippeD pushed a commit to Jean-PhilippeD/Gladys that referenced this pull request Oct 13, 2021
@atrovato atrovato deleted the single-range-box branch November 28, 2021 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants