Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#112) Add new method for creating empty release #370

Merged
merged 2 commits into from
Apr 19, 2021

Conversation

gep13
Copy link
Member

@gep13 gep13 commented Apr 19, 2021

Description

This is similar to the overload for passing in an input file, the
difference being that string.Empty is passed in, rather than reading
the contents of the file, and then creating a release.

Related Issue

#112

Motivation and Context

This allows the creation of an empty release, to allow for starting the release process, without having actually done any work.

How Has This Been Tested?

New unit tests have been added, similar to existing functionality.

Screenshots (if appropriate):

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@gep13 gep13 requested a review from AdmiringWorm April 19, 2021 20:35
Copy link
Member

@AdmiringWorm AdmiringWorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, just a small typo.

src/GitReleaseManager.Core/Options/CreateSubOptions.cs Outdated Show resolved Hide resolved
gep13 added 2 commits April 19, 2021 21:41
This is similar to the overload for passing in an input file, the
difference being that string.Empty is passed in, rather than reading
the contents of the file, and then creating a release.
@gep13 gep13 requested a review from AdmiringWorm April 19, 2021 20:43
Copy link
Member

@AdmiringWorm AdmiringWorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AdmiringWorm AdmiringWorm enabled auto-merge April 19, 2021 20:44
@AdmiringWorm AdmiringWorm merged commit 776b55c into GitTools:develop Apr 19, 2021
gittools-bot pushed a commit that referenced this pull request Apr 19, 2021
Merge pull request #370 from gep13/feature/GH-112
@gep13 gep13 deleted the feature/GH-112 branch April 20, 2021 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants