Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot create empty releases without Milestone or InputFilePath #112

Closed
kristho91 opened this issue Mar 15, 2018 · 8 comments
Closed

Cannot create empty releases without Milestone or InputFilePath #112

kristho91 opened this issue Mar 15, 2018 · 8 comments
Labels
Feature
Milestone
0.12.0

Comments

@kristho91
Copy link

As of today it seems it's only possible to create a new release if either Milestone or InputFilePath is specified.
It could be great if it was possible to create an empty release with neither of those parameters.
@gep13
Copy link
Member

gep13 commented Jan 6, 2020

@kristho91 thanks for raising this issue. I am just going through a process of triaging some issues, to know what to bring into the next release. Can you help me understand what the use case is for this issue? Why would you need to create an empty release?

@AdmiringWorm
Copy link
Member

@gep13 I can see one use case (for me at least).

When initially creating a library/application I typically don't really create a issue for it (until I have to), so being able to run GRM without the need for existing issues would be useful in these cases.

@gep13
Copy link
Member

gep13 commented Jan 6, 2020

@AdmiringWorm what would GRM bring to the table though that wouldn't be provided by simply creating the release through the UI? Or is it just the ability to automate that process? Happy to add this in, I just don't see an immediate benefit.

@gep13 gep13 added this to the 0.11.0 milestone Jan 6, 2020
@gep13 gep13 added the Feature label Jan 6, 2020
@AdmiringWorm
Copy link
Member

Or is it just the ability to automate that process?

This ^^ for me. No other benefit AFAIK

@AdmiringWorm
Copy link
Member

In general though, I do believe that GRM should throw an error on empty releases, but maybe adding a --empty switch or something (which skips the entire gathering of issues step).

@AdmiringWorm
Copy link
Member

Could also be beneficial when working on build scripts to see if all is working as it should (that grm can create the release).

@gep13
Copy link
Member

gep13 commented Jan 6, 2020

@AdmiringWorm said...
Could also be beneficial when working on build scripts to see if all is working as it should (that grm can create the release).

That's true.

@gep13 gep13 modified the milestones: 0.11.0, 0.12.0 Mar 16, 2020
gep13 referenced this issue in gep13/GitReleaseManager Apr 19, 2021
@gep13
(#112) Add new method for creating empty release
d315f00 
This is similar to the overload for passing in an input file, the
difference being that string.Empty is passed in, rather than reading
the contents of the file, and then creating a release.
@gep13 gep13 mentioned this issue Apr 19, 2021
Merged
6 tasks
gep13 referenced this issue in gep13/GitReleaseManager Apr 19, 2021
@gep13
(#112) Add new method for creating empty release
31255f2 
This is similar to the overload for passing in an input file, the
difference being that string.Empty is passed in, rather than reading
the contents of the file, and then creating a release.
gep13 referenced this issue in gep13/GitReleaseManager Apr 19, 2021
@gep13
(#112) Updated docs with new command option
a606dce
AdmiringWorm added a commit that referenced this issue Apr 19, 2021
@AdmiringWorm
Merge pull request #370 from gep13/feature/GH-112
776b55c
gittools-bot pushed a commit that referenced this issue Apr 19, 2021
@web-flow
Continuous Integration Publish: 776b55c
3da56a6 
Merge pull request #370 from gep13/feature/GH-112
@gep13 gep13 closed this as completed Apr 22, 2021
gep13 referenced this issue in gep13/GitReleaseManager May 10, 2021
@gep13
Merge branch 'develop' into release/0.12.0
7f1a9ae 
* develop:
  (build) Remove error action preference from build script
  Bump YamlDotNet from 11.0.1 to 11.1.1 in /src
  (#112) Updated docs with new command option
  (#112) Add new method for creating empty release
gep13 added a commit that referenced this issue May 31, 2021
@gep13
Merge branch 'release/0.12.0'
7a29d7e 
* release/0.12.0: (181 commits)
  (build) Fix unit tests
  Bump ApprovalTests from 5.4.7 to 5.5.0 in /src
  (#379) Validate old config file do not exist
  (#377) Add UploadUrl property to release model
  (#373) Ensure that release is located correctly
  (#374) Remove case sensitive search
  (#371) Add missing AutoMapper maps
  (#372) Always register TemplateRepository
  (build) Remove error action preference from build script
  Bump YamlDotNet from 11.0.1 to 11.1.1 in /src
  (#112) Updated docs with new command option
  (#112) Add new method for creating empty release
  (#113) Update unit tests for new functionality
  (#113) Collect all invalid issues together
  (#99) Fix unit tests
  (#99) Add SkipPrereleases option
  (#285) Fix editorconfig violations
  (maint) Run dotnet format
  (#143) Only build on Windows for time being
  (#143) Try running just Mac and Windows
  ...
gittools-bot pushed a commit that referenced this issue May 31, 2021
@gep13
Continuous Integration Publish: 7a29d7e
bb0bb10 
Merge branch 'release/0.12.0'

* release/0.12.0: (181 commits)
  (build) Fix unit tests
  Bump ApprovalTests from 5.4.7 to 5.5.0 in /src
  (#379) Validate old config file do not exist
  (#377) Add UploadUrl property to release model
  (#373) Ensure that release is located correctly
  (#374) Remove case sensitive search
  (#371) Add missing AutoMapper maps
  (#372) Always register TemplateRepository
  (build) Remove error action preference from build script
  Bump YamlDotNet from 11.0.1 to 11.1.1 in /src
  (#112) Updated docs with new command option
  (#112) Add new method for creating empty release
  (#113) Update unit tests for new functionality
  (#113) Collect all invalid issues together
  (#99) Fix unit tests
  (#99) Add SkipPrereleases option
  (#285) Fix editorconfig violations
  (maint) Run dotnet format
  (#143) Only build on Windows for time being
  (#143) Try running just Mac and Windows
  ...
@gittools-bot
Copy link
Contributor

🎉 This issue has been resolved in version 0.12.0 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

gittools-bot pushed a commit that referenced this issue May 31, 2021
@gep13
Continuous Integration Publish: 7a29d7e
007cc69 
Merge branch 'release/0.12.0'

* release/0.12.0: (181 commits)
  (build) Fix unit tests
  Bump ApprovalTests from 5.4.7 to 5.5.0 in /src
  (#379) Validate old config file do not exist
  (#377) Add UploadUrl property to release model
  (#373) Ensure that release is located correctly
  (#374) Remove case sensitive search
  (#371) Add missing AutoMapper maps
  (#372) Always register TemplateRepository
  (build) Remove error action preference from build script
  Bump YamlDotNet from 11.0.1 to 11.1.1 in /src
  (#112) Updated docs with new command option
  (#112) Add new method for creating empty release
  (#113) Update unit tests for new functionality
  (#113) Collect all invalid issues together
  (#99) Fix unit tests
  (#99) Add SkipPrereleases option
  (#285) Fix editorconfig violations
  (maint) Run dotnet format
  (#143) Only build on Windows for time being
  (#143) Try running just Mac and Windows
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature
Projects
None yet
Milestone
0.12.0
Development

No branches or pull requests
4 participants
@gep13 @AdmiringWorm @kristho91 @gittools-bot