Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Github actions #119

Merged
merged 12 commits into from
Feb 11, 2022
Merged

Update Github actions #119

merged 12 commits into from
Feb 11, 2022

Conversation

jwildfire
Copy link
Contributor

@jwildfire jwildfire commented Feb 9, 2022

Details

Fixing code coverage in action

Risk Assessment

Risk: Low
Mitigation Strategy:

  • Qualification Testing
  • Unit Testing
  • Code Review
  • QC
  • Automated Testing
    Notes:
    CI only.

@jwildfire jwildfire self-assigned this Feb 9, 2022
@jwildfire
Copy link
Contributor Author

Updated covr to run a basic coverage report in actions. Can consider enabling codecov later.

Also fixed #101 again. For real this time I think ...

This was linked to issues Feb 10, 2022
@jwildfire jwildfire changed the title try different coverage calc. #58 Update Github actions Feb 10, 2022
@jwildfire jwildfire requested a review from kodesiba February 10, 2022 16:50
@jwildfire jwildfire linked an issue Feb 10, 2022 that may be closed by this pull request
@kodesiba
Copy link
Contributor

@jwildfire this looks like it's working. Only other thing I could think of is would a machine user with a GitHub Personal Access Token be a better approach for the clindata install or is this way good enough to leave as is?

@jwildfire jwildfire merged commit c67b232 into dev Feb 11, 2022
@mattroumaya mattroumaya deleted the fix-58 branch April 12, 2022 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bugfix: Add remote for valtools Import test data from clindata Add automated code coverage
2 participants