Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: allow for more complex specs to be checked properly #1900

Closed
lauramaxwell opened this issue Oct 18, 2024 · 0 comments · Fixed by #1901
Closed

Bugfix: allow for more complex specs to be checked properly #1900

lauramaxwell opened this issue Oct 18, 2024 · 0 comments · Fixed by #1901
Assignees
Milestone

Comments

@lauramaxwell
Copy link
Contributor

Expected Behavior

users should be able to require _all columns of a given df, and also specify type for specific columns in specs and checkSpec() will check those columns appropriately, See below for example spec.

image

Current Behavior

right now checkSpec() doesn't check those columns because _all is used for required, so it currently skips the type step as well due to some faulty logic.

Possible Solution

updated logic in checkSpec to

Steps to Reproduce

Context (Environment)

Possible Implementation

Additional Comments

@lauramaxwell lauramaxwell added this to the v2.1.1 milestone Oct 18, 2024
@lauramaxwell lauramaxwell self-assigned this Oct 18, 2024
lauramaxwell added a commit that referenced this issue Oct 18, 2024
Closes #1890 and #1900 to properly check for dates and fix other bugs in checkSpec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant