Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: CheckSpec needs to check for Dates properly #1890

Closed
lauramaxwell opened this issue Oct 15, 2024 · 0 comments · Fixed by #1901
Closed

Bugfix: CheckSpec needs to check for Dates properly #1890

lauramaxwell opened this issue Oct 15, 2024 · 0 comments · Fixed by #1901
Assignees
@lauramaxwell
Milestone
v2.1.1

Comments

@lauramaxwell
Copy link
Contributor

Expected Behavior

when spec has a type: Date, it should check to make sure that the column contains dates

Current Behavior

the mode() function reads dates as numeric, so the test fails if type: Date is specified

Possible Solution

use class() instead of mode() for dates

Steps to Reproduce

Context (Environment)

Possible Implementation

Additional Comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lauramaxwell lauramaxwell

Labels
None yet
Projects
None yet
Milestone
v2.1.1
1 participant
@lauramaxwell