feat: Input upload disabled based on channel config #585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mahboubii
commented
Oct 19, 2020
| } | ||
| maxNumberOfFiles={messageInput.maxFilesLeft} |
There was a problem hiding this comment.
EditMessageForm changed regarding max attachments was missing from #577
|
Size Change: +206 B (0%) Total Size: 1.26 MB
ℹ️ View Unchanged
|
vini-btc
approved these changes
Oct 19, 2020
vini-btc
reviewed
Oct 19, 2020
| @@ -687,8 +687,11 @@ export default function useMessageInputState(props) { | |||
|
|
|||
| const maxFilesLeft = maxFilesAllowed - numberOfUploads; | |||
|
|
|||
| const isUploadEnabled = channel?.getConfig?.()?.uploads !== false; | |||
There was a problem hiding this comment.
A small suggestion, as I think this line is a little bit tricky to read. Feel free to ignore it.
Suggested change
| const isUploadEnabled = channel?.getConfig?.()?.uploads !== false; | |
| const uploadConfig = channel?.getConfig?.()?.uploads; | |
| const isUploadEnabled = typeof uploadConfig === 'undefined' || uploadConfig === true; |
There was a problem hiding this comment.
or it could be null as well 😅 maybe just adding a comment would do, so we're sure the undefined|null !== false was intended.
There was a problem hiding this comment.
agree, this is easier to read, but there are few more instances of channel?.getConfig?.().X !== false for other properties across the codebase, so let's keep this one similar to them. we can simplify them all together later
delete-merged-branch
bot
deleted the
feature/input-upload-channel-config
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.