-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CRS-293 Max attachments #577
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: +6.83 kB (0%) Total Size: 1.26 MB
ℹ️ View Unchanged
|
@@ -96,7 +100,7 @@ Channel.propTypes = { | |||
* @param {User} user Target [user object](https://getstream.io/chat/docs/#chat-doc-set-user) which is hovered | |||
*/ | |||
onMentionsHover: PropTypes.func, | |||
/** Weather to allow multiple attachment uploads */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤣
jaapbakker88
approved these changes
Oct 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submit a pull request
CLA
Description of the pull request
Draft: relies on GetStream/react-file-utils#22. Relates to #565
This PR uses
channelContext.maxNumberOfFiles
to prevent the user from uploading too many files. It does so by doing two things:maxNumberOfFiles
prop inImageDropzone
(part ofreact-file-utils
)Other fixes:
channelContext.multipleUploads
is set to false, you can now only upload a single file (and its default value is nowtrue
)To do:
react-file-utils
)