Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixes #11977][Backport 4.2.x] B/R should only deal with data #12006

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

etj
Copy link
Contributor

@etj etj commented Feb 29, 2024

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • This PR passes the QA checks: black geonode && flake8 geonode
  • Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates
  • Commits adding new texts do use gettext and have updated .po / .mo files (without location infos)

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@cla-bot cla-bot bot added the cla-signed CLA Bot: community license agreement signed label Feb 29, 2024
Copy link

codecov bot commented Feb 29, 2024

Codecov Report

Merging #12006 (4a0f3c0) into 4.2.x (e53bdef) will increase coverage by 0.16%.
The diff coverage is 11.11%.

Additional details and impacted files
@@            Coverage Diff             @@
##            4.2.x   #12006      +/-   ##
==========================================
+ Coverage   62.96%   63.12%   +0.16%     
==========================================
  Files         877      877              
  Lines       52607    52472     -135     
  Branches     6612     6580      -32     
==========================================
  Hits        33125    33125              
+ Misses      17960    17825     -135     
  Partials     1522     1522              

@giohappy giohappy self-requested a review March 6, 2024 10:34
@giohappy giohappy merged commit 4b8a169 into 4.2.x Mar 6, 2024
14 of 15 checks passed
@giohappy giohappy deleted the 11977_42x_br branch March 6, 2024 10:34
@giohappy giohappy added this to the 4.2.3 milestone Mar 14, 2024
chumano pushed a commit to cec-tris/geonode that referenced this pull request Apr 25, 2024
chumano pushed a commit to cec-tris/geonode that referenced this pull request Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed CLA Bot: community license agreement signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants