Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

B/R should only deal with data #11977

Closed
etj opened this issue Feb 21, 2024 · 3 comments
Closed

B/R should only deal with data #11977

etj opened this issue Feb 21, 2024 · 3 comments

Comments

@etj
Copy link
Contributor

etj commented Feb 21, 2024

Expected Behavior

After the restore, only data should be changed, not the file inside the libs

Actual Behavior

Some files (also in geonode-mapstore-client) are overwritten.
In particular, we found the the index.html template of geonode-mapstore-client overwritten with the empty one from geonode, so the HTTP request to the root path of the geonode instance would return a blank page.

Steps to Reproduce the Problem

After a B/R procedure, the restored system retruned a blank root page.

Specifications

  • GeoNode version: tried on 4.1.4
  • Installation type: geonode-project
  • Installation method (manual, docker):
@giohappy
Copy link
Contributor

Templates shouldn't be part of the B/R IMHO. They're code, not data.
I would completely remove the templates from the B/R procedure.

@etj
Copy link
Contributor Author

etj commented Feb 28, 2024

Also the trees of LOCALE_PATHS are put in the backup zip and then restored.

@etj
Copy link
Contributor Author

etj commented Feb 29, 2024

Also static_dirs and static_root should be excluded.

@etj etj changed the title B/R: Restore procedure overwrites templates in external modules B/R should only deal with data Feb 29, 2024
giohappy pushed a commit that referenced this issue Feb 29, 2024
* [Fixes #11977] B/R should only deal with data

* [Fixes #11977] B/R should only deal with data
chumano pushed a commit to cec-tris/geonode that referenced this issue Apr 25, 2024
chumano pushed a commit to cec-tris/geonode that referenced this issue Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants