Enhance adb.process(), Fix Android Debugging under GDB #834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
zachriggle
force-pushed
the
dev
branch
2 times, most recently
from
19b7132 to
f3968af
Compare
|
This is officially stalled, I haven't had time to work on this in a while. I'm leaving the PR open for another while, since Pull Requests are free 😄 |
|
Housekeeping: Closing this Pull Request so that it doesn't show as outstanding. I might work on this in the future at some point, but have no cycles currently. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code for
adb.process()doesn't set many convenience variables on the object it returns, which othertubes.processcode does do..argv.env.executable.pidAdditionally, at some point all of the GDB debugging stuff broke and nobody noticed, because nobody ever used it except me.
Note that this has #833 cherry-picked and squashed, so that I could test with those changes.