Defer attempts to start ADB server until we actually fail to connect #833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Verified that this did actually run all of the Android tests |
|
Merging to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
adb.protocolcode attempts to be kind and start the ADB server if the user had not already done so (e.g. on a freshly-booted machine).However, it attempts to do this on every connection. Because of the way that ADB works, this shouldn't actually cause any issues, since the new server process will just fail to bind the port and exit silently.
This adds a bit of overhead (lots of spawned processes) and takes up time in tight loops.
Defer attempting to kick-start the ADB server until we actually fail a connection attempt.