small SceneReader/writer updates, + a branch in SceneProcedural that renders VisibleRenderables #71
Conversation
…ard coded framerate. Also removed the SceneReader::cache() in favor of IECore::SharedSceneInterfaces, and made the reader ignore a couple of attributes automatically written by the SceneCache, to fix a test failure
| @@ -51,6 +51,8 @@ class SceneReader : public FileSource | |||
| virtual ~SceneReader(); | |||
|
|
|||
| IE_CORE_DECLARERUNTIMETYPEDEXTENSION( SceneReader, SceneReaderTypeId, FileSource ) | |||
|
|
|||
| static const double s_frameRate; | |||
There was a problem hiding this comment.
Since this is a temporary thing until we get fps/time stored in the context, it shouldn't be public - that just encourages other code to become reliant upon it. Can you just make it a static variable defined in SceneReader.cpp please? If you need to access it from SceneWriter.cpp too then just declare it again there - I'd rather the evil of duplicating that definition than the evil of introducing public fields we can't support going forwards...
Also note that we prefix statics with g_ and not s_.
| { | ||
| renderable->render( renderer ); | ||
| break; // no motion blur for these chappies. | ||
| } | ||
|
|
There was a problem hiding this comment.
This seems totally unrelated to the rest of this pull request - in the future we should make sure we deal with individual topics separately.
There was a problem hiding this comment.
Yup - looks like this was a stowaway...
|
voila - changed the static var names, made them private, and tweaked that test... |
small SceneReader/writer updates, + a branch in SceneProcedural that renders VisibleRenderables
Framerate stuff in SceneReader/Writer... Maybe I should just push small things like this? Thought I'd make a pull request anyway for practice...