Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Primitive generators #334

Merged
merged 6 commits into from
Jun 3, 2013
Merged

Primitive generators #334

merged 6 commits into from
Jun 3, 2013

Conversation

andrewkaufman
Copy link
Contributor

  • Added Cube and Sphere generators
  • Added divisions plug to Plane node
  • Removed SphereNode from the node menu

Fixes #97.

@johnhaddon
Copy link
Member

All looks good to me once the SphereNode::compute() comment is addressed.

johnhaddon added a commit that referenced this pull request Jun 3, 2013
@johnhaddon
Merge pull request #334 from andrewkaufman/primitiveGenerators
a958445 
Primitive generators
@johnhaddon johnhaddon merged commit a958445 into GafferHQ:master Jun 3, 2013
@andrewkaufman andrewkaufman deleted the primitiveGenerators branch June 3, 2013 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consolidate primitive generators
2 participants
@andrewkaufman @johnhaddon